[Download Home] Make the space display usable

[Download Home] Make the space display usable

Matches the updated mock linked in the bug, with some liberties.

* Makes the progress bar represent two values: how much space is
  used by other apps and how much is used by downloads.

* Strings are changed to reflect the updated mock.

* Instead of total space, free space is shown.

* Tests are updated to account for the asynchronous nature of
  retrieving how much free space is available.

Screenshot:
https://drive.google.com/open?id=0B8k2SmEN8xS3UXk2ZkVQbWVtc0k

BUG=643795
Committed: https://crrev.com/01487868d916766b3ea5767e7876b7af09279660
Cr-Commit-Position: refs/heads/master@{#428856}

[gone, 2016-10-28 21:10:15]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-10-28 21:24:37]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-10-28 21:24:37]

Whenever you get a chance, PTAL.

[commit-bot: I haz the power, 2016-10-28 21:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:47:26]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-10-31 18:24:55]

lgtm

https://codereview.chromium.org/2464473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
(right):

https://codereview.chromium.org/2464473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java:58:
StorageSizeTask(boolean fetchTotalSize) {
nit: add a JavaDoc explaining what fetchTotalSize controls (and what is fetched
if this is false)?

[gone, 2016-10-31 20:13:13]

dfalcantara@chromium.org changed reviewers:
+ nyquist@chromium.org

[gone, 2016-10-31 20:13:14]

Tommy: Can you look over the change to base/?  Just adds a new method.

Theresa: Thanks!

https://codereview.chromium.org/2464473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
(right):

https://codereview.chromium.org/2464473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java:58:
StorageSizeTask(boolean fetchTotalSize) {
On 2016/10/31 18:24:55, Theresa Wellington wrote:
> nit: add a JavaDoc explaining what fetchTotalSize controls (and what is
fetched
> if this is false)?

Done.

[gone, 2016-10-31 20:13:44]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 20:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:05:37]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-10-31 22:58:34]

base lgtm

[gone, 2016-10-31 23:05:39]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-10-31 23:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2464473002/#ps20001
(title: "Added javadoc")

[commit-bot: I haz the power, 2016-10-31 23:06:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:11:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 23:15:01]

Description was changed from

==========
[Download Home] Make the space display usable

Matches the updated mock linked in the bug, with some liberties.

* Makes the progress bar represent two values: how much space is
  used by other apps and how much is used by downloads.

* Strings are changed to reflect the updated mock.

* Instead of total space, free space is shown.

* Tests are updated to account for the asynchronous nature of
  retrieving how much free space is available.

Screenshot:
https://drive.google.com/open?id=0B8k2SmEN8xS3UXk2ZkVQbWVtc0k

BUG=643795
==========

to

==========
[Download Home] Make the space display usable

Matches the updated mock linked in the bug, with some liberties.

* Makes the progress bar represent two values: how much space is
  used by other apps and how much is used by downloads.

* Strings are changed to reflect the updated mock.

* Instead of total space, free space is shown.

* Tests are updated to account for the asynchronous nature of
  retrieving how much free space is available.

Screenshot:
https://drive.google.com/open?id=0B8k2SmEN8xS3UXk2ZkVQbWVtc0k

BUG=643795

Committed: https://crrev.com/01487868d916766b3ea5767e7876b7af09279660
Cr-Commit-Position: refs/heads/master@{#428856}
==========

[commit-bot: I haz the power, 2016-10-31 23:15:02]

Patchset 2 (id:??) landed as
https://crrev.com/01487868d916766b3ea5767e7876b7af09279660
Cr-Commit-Position: refs/heads/master@{#428856}