Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2464253002: Fix flaky test paint/invalidation/background-resize-height.html (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky test paint/invalidation/background-resize-height.html Add capturePixelsThenAsync() to ensure image decoding is finished before running the test, to avoid flakiness of "contentsOpaque" in the dumped layer tree. Also disabled the fixed height gradient case because it produces invisible pixel difference. BUG=658479 Committed: https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9 Cr-Commit-Position: refs/heads/master@{#429506}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaseline-cl #

Patch Set 3 : Remove extra files (should belong to another CL) #

Messages

Total messages: 23 (14 generated)
Xianzhu
4 years, 1 month ago (2016-11-01 23:07:14 UTC) #4
chrishtr
https://codereview.chromium.org/2464253002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html File third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html (right): https://codereview.chromium.org/2464253002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html#newcode96 third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html:96: <!-- This produces invisible pixel difference. Just delete this ...
4 years, 1 month ago (2016-11-01 23:20:20 UTC) #5
Xianzhu
https://codereview.chromium.org/2464253002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html File third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html (right): https://codereview.chromium.org/2464253002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html#newcode96 third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html:96: <!-- This produces invisible pixel difference. On 2016/11/01 23:20:20, ...
4 years, 1 month ago (2016-11-01 23:59:19 UTC) #6
Xianzhu
On 2016/11/01 23:59:19, Xianzhu wrote: > https://codereview.chromium.org/2464253002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html > File > third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html > (right): > > ...
4 years, 1 month ago (2016-11-02 23:27:19 UTC) #9
chrishtr
lgtm
4 years, 1 month ago (2016-11-03 00:41:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464253002/20001
4 years, 1 month ago (2016-11-03 00:41:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464253002/40001
4 years, 1 month ago (2016-11-03 00:43:29 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 01:47:08 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 01:49:25 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9
Cr-Commit-Position: refs/heads/master@{#429506}

Powered by Google App Engine
This is Rietveld 408576698