third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html - Issue 2464253002: Fix flaky test paint/invalidation/background-resize-height.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html

Issue 2464253002: Fix flaky test paint/invalidation/background-resize-height.html (Closed)

Patch Set: Remove extra files (should belong to another CL) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html

diff --git a/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html b/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html

index 88f87468ce3b7edf6502f5398fc982613794462b..01cb4e57fad795b14d1f447394c12f8f1faa0334 100644

--- a/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html

+++ b/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html

@@ -1,9 +1,19 @@

<!DOCTYPE html>

+window.testIsAsync = true;

+function doTest() {

+ document.getElementById('container').style.height = '550px';

+ finishRepaintTest();

function repaintTest()

{

- document.getElementById('container').style.height = '550px';

+ if (window.testRunner) {

+ // This ensures finish of image decoding before running the test.

+ testRunner.capturePixelsAsyncThen(doTest);

+ } else {

+ doTest();

+ }

}

window.onload = runRepaintAndPixelTest;

</script>

@@ -52,7 +62,7 @@ window.onload = runRepaintAndPixelTest;

left: 300px;

}

.center {

- background-position: center;

+ background-position: center;

left: 350px;

}

.no-repeat {

@@ -81,9 +91,8 @@ window.onload = runRepaintAndPixelTest;

- <div class="test generated cover"></div>

- <div class="test generated contain"></div>

- <div class="test generated fixed-height"></div>

+ <div class="test generated size-cover"></div>

+ <div class="test generated size-contain"></div>