Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2464163005: Drop support for [TreatUndefinedAs=NullString] (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, tzik, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop support for [TreatUndefinedAs=NullString] Because it was only used on nullable DOMString types, this does not change the generated bindings at all, and thus there is no change. BUG=460722 Committed: https://crrev.com/b3ccf01a59d182eee56040de8624d4b1b01abe73 Cr-Commit-Position: refs/heads/master@{#429590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -61 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 1 chunk +8 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DirectoryEntry.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/Entry.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/EntrySync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
foolip
PTAL
4 years, 1 month ago (2016-11-03 12:36:41 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-11-03 14:02:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464163005/1
4 years, 1 month ago (2016-11-03 14:06:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 15:17:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3ccf01a59d182eee56040de8624d4b1b01abe73 Cr-Commit-Position: refs/heads/master@{#429590}
4 years, 1 month ago (2016-11-03 15:40:53 UTC) #11
bashi
4 years, 1 month ago (2016-11-03 23:06:20 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698