Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: third_party/WebKit/Source/core/frame/History.idl

Issue 2464163005: Drop support for [TreatUndefinedAs=NullString] (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/fileapi/Blob.idl ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/History.idl
diff --git a/third_party/WebKit/Source/core/frame/History.idl b/third_party/WebKit/Source/core/frame/History.idl
index 54e643c594d94d09f5270a70dc3066b4da42dea9..fef8e1fdbaa62510270b50b6b93da475f753e3eb 100644
--- a/third_party/WebKit/Source/core/frame/History.idl
+++ b/third_party/WebKit/Source/core/frame/History.idl
@@ -36,7 +36,7 @@ interface History {
[CallWith=ExecutionContext] void back();
[CallWith=ExecutionContext] void forward();
// TODO(foolip): The SerializedScriptValue types should be any.
- // TODO(foolip): The title arguments should simply be 'DOMString title'.
- [RaisesException] void pushState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null);
- [RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null);
+ // TODO(foolip): The title arguments should not be nullable.
+ [RaisesException] void pushState(SerializedScriptValue data, DOMString? title, optional DOMString? url = null);
+ [RaisesException] void replaceState(SerializedScriptValue data, DOMString? title, optional DOMString? url = null);
};
« no previous file with comments | « third_party/WebKit/Source/core/fileapi/Blob.idl ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698