Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2464153003: GN: Fall back on dart_bootstrap where appropriate. (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Fall back on dart_bootstrap where appropriate. Committed: https://github.com/dart-lang/sdk/commit/f7799da7c5355359a662654ea5f9a9d8db5452c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -88 lines) Patch
M runtime/observatory/BUILD.gn View 1 8 chunks +84 lines, -74 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 3 chunks +11 lines, -1 line 0 comments Download
M tools/gn.py View 1 chunk +4 lines, -8 lines 0 comments Download
M utils/invoke_dart.gni View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
4 years, 1 month ago (2016-11-01 19:23:06 UTC) #2
Cutch
https://codereview.chromium.org/2464153003/diff/1/runtime/vm/BUILD.gn File runtime/vm/BUILD.gn (right): https://codereview.chromium.org/2464153003/diff/1/runtime/vm/BUILD.gn#newcode485 runtime/vm/BUILD.gn:485: dart_bootstrap = rebase_path("$dart_out_dir/dart_bootstrap.exe") This `if (is_win) { } else ...
4 years, 1 month ago (2016-11-01 19:33:52 UTC) #3
Cutch
oops, forgot LGTMwC
4 years, 1 month ago (2016-11-01 19:34:05 UTC) #4
zra
https://codereview.chromium.org/2464153003/diff/1/runtime/vm/BUILD.gn File runtime/vm/BUILD.gn (right): https://codereview.chromium.org/2464153003/diff/1/runtime/vm/BUILD.gn#newcode485 runtime/vm/BUILD.gn:485: dart_bootstrap = rebase_path("$dart_out_dir/dart_bootstrap.exe") On 2016/11/01 19:33:52, Cutch wrote: > ...
4 years, 1 month ago (2016-11-01 19:59:28 UTC) #5
zra
4 years, 1 month ago (2016-11-01 19:59:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f7799da7c5355359a662654ea5f9a9d8db5452c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698