Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: utils/invoke_dart.gni

Issue 2464153003: GN: Fall back on dart_bootstrap where appropriate. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/invoke_dart.gni
diff --git a/utils/invoke_dart.gni b/utils/invoke_dart.gni
index ad3a7f83b0d9df33e9d44b03185ca3bf7033ee73..bc4747a0bde957914438977b30e8b33ede16e943 100644
--- a/utils/invoke_dart.gni
+++ b/utils/invoke_dart.gni
@@ -4,6 +4,12 @@
_dart_root = rebase_path("..")
+if (defined(is_win) && is_win) {
+ dart_executable_suffix = ".exe"
+} else {
+ dart_executable_suffix = ""
+}
+
template("invoke_dart") {
assert(defined(invoker.outputs), "invoke_dart must specify outputs")
extra_deps = []
@@ -29,11 +35,7 @@ template("invoke_dart") {
dart_out_dir =
get_label_info("$relative_dart_root/runtime/bin:dart($host_toolchain)",
"root_out_dir")
- if (is_win) {
- dart = rebase_path("$dart_out_dir/dart.exe")
- } else {
- dart = rebase_path("$dart_out_dir/dart")
- }
+ dart = rebase_path("$dart_out_dir/dart$dart_executable_suffix")
inputs = [ dart ] + extra_inputs
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698