Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2464143004: Upstream Context.BIND_EXTERNAL_SERVICE (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
index f0d37a92ad34e6ab2bfa2059984be1a15744bb3d..fa0bf2dbcc34b5edd4723a09423575bbfc7c2135 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
@@ -680,10 +680,8 @@ public class ChildProcessLauncher {
// name. In WebAPK, ChildProcessCreationParams are initialized with WebAPK's
// package name. Make a copy of the WebAPK's params, but replace the package with
// Chrome's package to use when initializing a non-renderer processes.
- // TODO(michaelbai | hanxi): crbug.com/620102. Cleans up the setting of
- // ChildProcessCreationParams after using N sdk.
params = new ChildProcessCreationParams(context.getPackageName(),
- params.getExtraBindFlags(), params.getLibraryProcessType());
+ params.getLibraryProcessType());
}
if (ContentSwitches.SWITCH_GPU_PROCESS.equals(processType)) {
callbackType = CALLBACK_FOR_GPU_PROCESS;

Powered by Google App Engine
This is Rietveld 408576698