Enabling Aura-Mus clients to submit frames to Mus.

Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886
Committed: https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6
Cr-Commit-Position: refs/heads/master@{#429448}

[mfomitchev, 2016-11-01 20:39:39]

sky: Does this look reasonable? Not sure if it's worth moving GPU Service
classes into a separate folder/component?

[mfomitchev, 2016-11-01 20:42:07]

mfomitchev@chromium.org changed reviewers:
+ sky@chromium.org

[mfomitchev, 2016-11-01 20:42:07]

sky: Does this look reasonable? Not sure if it's worth moving GPU Service
classes into a separate folder/component?

[sky, 2016-11-01 20:46:53]

Only one question about BUILD.gn and deps, everything else looks good.

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS
File ui/aura/mus/DEPS (right):

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS#newcode2
ui/aura/mus/DEPS:2: "+cc/ipc/mojo_compositor_frame_sink.mojom.h",
I noticed no new dependencies in BUILD.gn. Is that expected?

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
File ui/views/mus/surface_context_factory.cc (right):

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:60: aura::WindowPortMus* window_port =
aura::WindowPortMus::Get(host->window());
fyi: I think you want host->GetWindowWithServerWindow(), but I'm working on
getting rid of that right now. It's up to you if you want to change it.

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:106: else
no else here (see style guide).

[mfomitchev, 2016-11-01 21:01:59]

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS
File ui/aura/mus/DEPS (right):

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS#newcode2
ui/aura/mus/DEPS:2: "+cc/ipc/mojo_compositor_frame_sink.mojom.h",
On 2016/11/01 20:46:53, sky wrote:
> I noticed no new dependencies in BUILD.gn. Is that expected?

I forgot to add them. Somehow everything compiled though. Maybe because most
code paths are simply not exercised..

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
File ui/views/mus/surface_context_factory.cc (right):

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:60: aura::WindowPortMus* window_port =
aura::WindowPortMus::Get(host->window());
On 2016/11/01 20:46:53, sky wrote:
> fyi: I think you want host->GetWindowWithServerWindow(), but I'm working on
> getting rid of that right now. It's up to you if you want to change it.

Seems like I'd have to do a static cast from WTH to WTHMust to use that. Is that
ok?

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:106: else
On 2016/11/01 20:46:53, sky wrote:
> no else here (see style guide).

Acknowledged.

[mfomitchev, 2016-11-01 21:03:04]

Description was changed from

==========
Enabling Aura-Mus clients to submit surfaces to Mus.


BUG=660886
==========

to

==========
WIP: Enabling Aura-Mus clients to submit frames to Mus.

BUG=660886
==========

[sky, 2016-11-01 21:36:05]

It doesn't seem like you pushed a new patch.

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
File ui/views/mus/surface_context_factory.cc (right):

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:60: aura::WindowPortMus* window_port =
aura::WindowPortMus::Get(host->window());
On 2016/11/01 21:01:59, mfomitchev wrote:
> On 2016/11/01 20:46:53, sky wrote:
> > fyi: I think you want host->GetWindowWithServerWindow(), but I'm working on
> > getting rid of that right now. It's up to you if you want to change it.
> 
> Seems like I'd have to do a static cast from WTH to WTHMust to use that. Is
that
> ok?

Indeed you would have to do that. As I said, this will go away shortly so feel
free to leave it. https://codereview.chromium.org/2470963002/ nukes
GetWindowWithServerWindow.

[mfomitchev, 2016-11-01 21:49:44]

On 2016/11/01 21:36:05, sky wrote:
> It doesn't seem like you pushed a new patch.

I didn't intend to do it right away, sorry if my response was misleading. I will
update this tomorrow, already on the bus back home. rjkroege@ also said he
doesn't like moving all the GPU Service code to Aura and suggested gpu/ipc
instead, so I can also address that. That could probably be done in a separate
patch.

[sadrul, 2016-11-02 01:23:13]

On 2016/11/01 21:49:44, mfomitchev wrote:
> On 2016/11/01 21:36:05, sky wrote:
> > It doesn't seem like you pushed a new patch.
> 
> I didn't intend to do it right away, sorry if my response was misleading. I
will
> update this tomorrow, already on the bus back home. rjkroege@ also said he
> doesn't like moving all the GPU Service code to Aura and suggested gpu/ipc
> instead, so I can also address that. That could probably be done in a separate
> patch.

I think all the client-lib code should live in the same place. So aura would be
the better place for the GpuService code. Of course, it would continue to use
code from inside gpu/ipc/client for doing most of the actual work.

[mfomitchev, 2016-11-02 20:00:08]

Description was changed from

==========
WIP: Enabling Aura-Mus clients to submit frames to Mus.

BUG=660886
==========

to

==========
Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and 
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886
==========

[mfomitchev, 2016-11-02 20:00:31]

sky@, can you PTAL?

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS
File ui/aura/mus/DEPS (right):

https://codereview.chromium.org/2464123003/diff/1/ui/aura/mus/DEPS#newcode2
ui/aura/mus/DEPS:2: "+cc/ipc/mojo_compositor_frame_sink.mojom.h",
On 2016/11/01 21:01:59, mfomitchev wrote:
> On 2016/11/01 20:46:53, sky wrote:
> > I noticed no new dependencies in BUILD.gn. Is that expected?
> 
> I forgot to add them. Somehow everything compiled though. Maybe because most
> code paths are simply not exercised..

Done. Also removed a few dependencies/imports which weren't actually needed.

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
File ui/views/mus/surface_context_factory.cc (right):

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:60: aura::WindowPortMus* window_port =
aura::WindowPortMus::Get(host->window());
On 2016/11/01 21:36:05, sky wrote:
> On 2016/11/01 21:01:59, mfomitchev wrote:
> > On 2016/11/01 20:46:53, sky wrote:
> > > fyi: I think you want host->GetWindowWithServerWindow(), but I'm working
on
> > > getting rid of that right now. It's up to you if you want to change it.
> > 
> > Seems like I'd have to do a static cast from WTH to WTHMust to use that. Is
> that
> > ok?
> 
> Indeed you would have to do that. As I said, this will go away shortly so feel
> free to leave it. https://codereview.chromium.org/2470963002/ nukes
> GetWindowWithServerWindow.

Looks like your CL has landed, so I can just leave this the way it is.

https://codereview.chromium.org/2464123003/diff/1/ui/views/mus/surface_contex...
ui/views/mus/surface_context_factory.cc:106: else
On 2016/11/01 21:01:59, mfomitchev wrote:
> On 2016/11/01 20:46:53, sky wrote:
> > no else here (see style guide).
> 
> Acknowledged.

Done.

[sky, 2016-11-02 21:02:13]

LGTM

[mfomitchev, 2016-11-02 21:15:12]

mfomitchev@chromium.org changed reviewers:
+ piman@chromium.org

[mfomitchev, 2016-11-02 21:15:12]

piman@chromium.org: Please review changes in 

content/browser/compositor/
ui/aura/mus/DEPS

[piman, 2016-11-02 21:27:07]

So much duplication... What's the timeframe to remove the services/ui versions
of all these?

[mfomitchev, 2016-11-02 21:37:38]

On 2016/11/02 21:27:07, piman wrote:
> So much duplication... What's the timeframe to remove the services/ui versions
> of all these?

We are actively working on this. I'd say a couple of weeks, but sky@ might be
able to give a better estimate.

[piman, 2016-11-02 21:51:04]

ok, lgtm.

[mfomitchev, 2016-11-02 21:52:34]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:24:03]

Description was changed from

==========
Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and 
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886
==========

to

==========
Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and 
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886
==========

[commit-bot: I haz the power, 2016-11-02 23:24:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 23:27:01]

Description was changed from

==========
Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and 
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886
==========

to

==========
Enabling Aura-Mus clients to submit frames to Mus.

- Copying GPUService, WindowCompositorFrameSink, and supporting classes
  from services/ui/public/cpp/ to ui/aura/mus.
- Adding RequestCompositorFrameSink to WindowPortMus.
- Making SurfaceContextFactory work with Aura-Mus. Instead of getting
  ui::Window from the ui::Compositor, it uses AcceleratedWidget to find
  WTH and the corresponding root window.
- Ditto for GpuProcessTransportFactory
- SurfaceContextFactory, GpuProcessTransportFactory, and
  MusBrowserCompositorOutputSurface are made to work with both Aura-Mus
  as well as the old client library. This results in a bit of an awkward
  code with a few icky "ifs", but this is temporary until we get rid of
  the old client lib completely.
- Aura gets a few new deps, including cc, and gpu.

BUG=660886

Committed: https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6
Cr-Commit-Position: refs/heads/master@{#429448}
==========

[commit-bot: I haz the power, 2016-11-02 23:27:02]

Patchset 2 (id:??) landed as
https://crrev.com/3364e66eca1f71f542c2d9937acbf5ec288fcdc6
Cr-Commit-Position: refs/heads/master@{#429448}