Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2464093002: Revert of Consolidate implementation of ImageBitmapRenderingContext (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Consolidate implementation of ImageBitmapRenderingContext (patchset #3 id:40001 of https://codereview.chromium.org/2459233002/ ) Reason for revert: Speculative revert to fix offscreenCanvas-transferToImageBitmap-texImage2D.html. Failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1347 Error message is not helpful: "renderer crashed." Original issue's description: > Consolidate implementation of ImageBitmapRenderingContext > > To prepare for the shipping of ImageBitmapRenderingContext, we need more > layout test coverage. When we add more tests, we found that there are > some problem in our implementation. > > 1. transferFromImageBitmap API should be capable of throwing DOMException. > 2. After calling transferFromImageBitmap(bitmap), the bitmap should be > detached. > 3. When calling transferFromImageBitmap(bitmap), if bitmap has already > detached, this call should throw an InvalidStateError DOMException. > > The corresponding layout test cases are added. > > BUG=659156 > > Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0 > Cr-Commit-Position: refs/heads/master@{#428988} TBR=junov@chromium.org,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659156 Committed: https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de Cr-Commit-Position: refs/heads/master@{#429002}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
please use gerrit instead
Created Revert of Consolidate implementation of ImageBitmapRenderingContext
4 years, 1 month ago (2016-11-01 14:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464093002/1
4 years, 1 month ago (2016-11-01 14:50:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 14:51:53 UTC) #5
xidachen
On 2016/11/01 14:51:53, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) Thanks ...
4 years, 1 month ago (2016-11-01 14:54:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de Cr-Commit-Position: refs/heads/master@{#429002}
4 years, 1 month ago (2016-11-01 14:55:56 UTC) #8
please use gerrit instead
4 years, 1 month ago (2016-11-01 16:12:53 UTC) #9
Message was sent while issue was closed.
The bot is fixed. Speculation was correct.

Powered by Google App Engine
This is Rietveld 408576698