Chromium Code Reviews
DescriptionRevert of Consolidate implementation of ImageBitmapRenderingContext (patchset #3 id:40001 of https://codereview.chromium.org/2459233002/ )
Reason for revert:
Speculative revert to fix offscreenCanvas-transferToImageBitmap-texImage2D.html.
Failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1347
Error message is not helpful: "renderer crashed."
Original issue's description:
> Consolidate implementation of ImageBitmapRenderingContext
>
> To prepare for the shipping of ImageBitmapRenderingContext, we need more
> layout test coverage. When we add more tests, we found that there are
> some problem in our implementation.
>
> 1. transferFromImageBitmap API should be capable of throwing DOMException.
> 2. After calling transferFromImageBitmap(bitmap), the bitmap should be
> detached.
> 3. When calling transferFromImageBitmap(bitmap), if bitmap has already
> detached, this call should throw an InvalidStateError DOMException.
>
> The corresponding layout test cases are added.
>
> BUG=659156
>
> Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
> Cr-Commit-Position: refs/heads/master@{#428988}
TBR=junov@chromium.org,xidachen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659156
Committed: https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de
Cr-Commit-Position: refs/heads/master@{#429002}
Patch Set 1 #
Messages
Total messages: 9 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||