third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2464053003: Always paint background and shadow separately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2464053003: Always paint background and shadow separately (Closed)

Patch Set: Rebaseline-cl (invisible pixel changes along shadow edges) (The original Patch Set 2 was removed to get the try result in Patch Set 1) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/transforms/shadows-expected.png ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

index 3d22763256f5f7ca24867abfa768646cf100d59f..57836cc012ff3c39a814c3d4de958e34601ce155 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

@@ -369,10 +369,6 @@ class CORE_EXPORT LayoutBoxModelObject : public LayoutObject {

virtual void childBecameNonInline(LayoutObject* /*child*/) {}

- virtual bool boxShadowShouldBeAppliedToBackground(

- BackgroundBleedAvoidance,

- const InlineFlowBox* = nullptr) const;

// Overridden by subclasses to determine line height and baseline position.

virtual LayoutUnit lineHeight(

bool firstLine,