third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2464053003: Always paint background and shadow separately

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2464053003: Always paint background and shadow separately (Closed)

Patch Set: Rebaseline-cl (invisible pixel changes along shadow edges) (The original Patch Set 2 was removed to get the try result in Patch Set 1) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/transforms/shadows-expected.png ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.

5 * Copyright (C) 2010 Google Inc. All rights reserved.	5 * Copyright (C) 2010 Google Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 351 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
362 return hasInlineDirectionBordersOrPadding() \|\| marginStart() \|\| marginEnd();	362 return hasInlineDirectionBordersOrPadding() \|\| marginStart() \|\| marginEnd();

363 }	363 }

364 bool hasInlineDirectionBordersOrPadding() const {	364 bool hasInlineDirectionBordersOrPadding() const {

365 return borderStart() \|\| borderEnd() \|\| paddingStart() \|\| paddingEnd();	365 return borderStart() \|\| borderEnd() \|\| paddingStart() \|\| paddingEnd();

366 }	366 }

367	367

368 virtual LayoutUnit containingBlockLogicalWidthForContent() const;	368 virtual LayoutUnit containingBlockLogicalWidthForContent() const;

369	369

370 virtual void childBecameNonInline(LayoutObject* /child/) {}	370 virtual void childBecameNonInline(LayoutObject* /child/) {}

371	371

372 virtual bool boxShadowShouldBeAppliedToBackground(

373 BackgroundBleedAvoidance,

374 const InlineFlowBox* = nullptr) const;

375

376 // Overridden by subclasses to determine line height and baseline position.	372 // Overridden by subclasses to determine line height and baseline position.

377 virtual LayoutUnit lineHeight(	373 virtual LayoutUnit lineHeight(

378 bool firstLine,	374 bool firstLine,

379 LineDirectionMode,	375 LineDirectionMode,

380 LinePositionMode = PositionOnContainingLine) const = 0;	376 LinePositionMode = PositionOnContainingLine) const = 0;

381 virtual int baselinePosition(	377 virtual int baselinePosition(

382 FontBaseline,	378 FontBaseline,

383 bool firstLine,	379 bool firstLine,

384 LineDirectionMode,	380 LineDirectionMode,

385 LinePositionMode = PositionOnContainingLine) const = 0;	381 LinePositionMode = PositionOnContainingLine) const = 0;

(...skipping 138 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
524 std::unique_ptr<PaintLayer> m_layer;	520 std::unique_ptr<PaintLayer> m_layer;

525	521

526 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData;	522 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData;

527 };	523 };

528	524

529 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());	525 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());

530	526

531 } // namespace blink	527 } // namespace blink

532	528

533 #endif // LayoutBoxModelObject_h	529 #endif // LayoutBoxModelObject_h

OLD	NEW