chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc - Issue 246393004: Password bubble: Introduce a command to open the bubble.

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc

Issue 246393004: Password bubble: Introduce a command to open the bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: The bigger picture. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc

index dd64b61cac25935cc36723a97187860f6744f02a..6a835712082fc726fcbbaa75505a2105f40167d9 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc

@@ -4,13 +4,18 @@

#include "base/metrics/histogram_samples.h"

#include "base/prefs/pref_service.h"

-#include "base/strings/utf_string_conversions.cc"

+#include "base/strings/utf_string_conversions.h"

Peter Kasting 2014/04/25 22:12:02 Woooooww. Surprised this ever compiled...

Mike West 2014/04/28 10:52:56 Done.

#include "base/test/statistics_delta_reader.h"

+#include "chrome/app/chrome_command_ids.h"

vabr (Chromium) 2014/04/25 15:26:17 I'm a bit confused about these new includes -- are

Mike West 2014/04/28 10:52:56 This was overzealous copy/pasta. I'll trim these h

+#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_command_controller.h"

+#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/passwords/manage_passwords_bubble.h"

#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_mock.h"

#include "chrome/browser/ui/passwords/manage_passwords_icon.h"

#include "chrome/browser/ui/passwords/manage_passwords_icon_mock.h"

+#include "chrome/test/base/browser_with_test_window_test.h"

#include "chrome/test/base/testing_profile.h"

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/mock_password_manager_driver.h"