chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc - Issue 246393004: Password bubble: Introduce a command to open the bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

Issue 246393004: Password bubble: Introduce a command to open the bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: The bigger picture. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc » ('j') | chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

index 987077be01d2b7a690c8683d24ec5ac1872aab13..88c76e64107b753d5d0099dfe3bbbdab3dc51476 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

@@ -170,6 +170,8 @@ void ManagePasswordsBubbleUIController::UpdateIconAndBubbleState(

if (manage_passwords_bubble_needs_showing_) {

DCHECK(state == ManagePasswordsIcon::PENDING_STATE);

+ // TODO(mkwst): Replace this with execution of a browser command once we

+ // can pipe a CommandUpdater down here.

icon->ShowBubbleWithoutUserInteraction();

manage_passwords_bubble_needs_showing_ = false;

}