Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2463913002: Do not replace up-to-date System Flash with Component Flash. (Closed)

Created:
4 years, 1 month ago by waffles
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Do not replace up-to-date System Flash with Component Flash. BUG=656058 TEST=Cases 1, 3, 5 from https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit#heading=h.pe0xr0h8vcrv Review-Url: https://codereview.chromium.org/2434103005 Cr-Commit-Position: refs/heads/master@{#428205} (cherry picked from commit 151a7690b7312bed56784b8b953cce11e03a1085) Committed: https://chromium.googlesource.com/chromium/src/+/ce3939e74844e2610689b5fc56ebb305636adf87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -215 lines) Patch
M base/files/file_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/files/file_util_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M base/files/file_util_win.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +2 lines, -21 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 6 chunks +8 lines, -24 lines 0 comments Download
M chrome/common/chrome_content_client_unittest.cc View 1 chunk +7 lines, -75 lines 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 chunk +0 lines, -13 lines 0 comments Download
M content/public/common/pepper_plugin_info.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
waffles
4 years, 1 month ago (2016-10-31 17:55:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce3939e74844e2610689b5fc56ebb305636adf87.

Powered by Google App Engine
This is Rietveld 408576698