Do not replace up-to-date System Flash with Component Flash.

Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit#heading=h.pe0xr0h8vcrv

Committed: https://crrev.com/151a7690b7312bed56784b8b953cce11e03a1085
Cr-Commit-Position: refs/heads/master@{#428205}

[waffles, 2016-10-21 17:12:04]

waffles@chromium.org changed reviewers:
+ wfh@chromium.org

[waffles, 2016-10-21 17:12:04]

Will, please take a look.

Do you think it's worth checking whether the existing _system_ Flash is on a
network drive (but component Flash is not)? The code did not previously do this,
so I didn't do it here.

(I'm not sure why we even register the system plugin in such a case.)

[Will Harris, 2016-10-21 17:18:29]

On 2016/10/21 17:12:04, waffles wrote:
> Will, please take a look.
> 
> Do you think it's worth checking whether the existing _system_ Flash is on a
> network drive (but component Flash is not)? The code did not previously do
this,
> so I didn't do it here.

I don't think we should cater for system flash being on a network drive, that
would be incredibly unusual and I don't think it's even possible to have
%programfiles% on a network drive and for Windows to still work. It would also
likely completely brick Chrome's sandbox launch.

> 
> (I'm not sure why we even register the system plugin in such a case.)

Does the code in ChromeContentClient::FindMostRecentPlugin also have to change?

[waffles, 2016-10-21 17:59:21]

> Does the code in ChromeContentClient::FindMostRecentPlugin also have to
change?

Not for Windows, but good point for other platforms. Actually, this change in
behavior enables us to make many simplifications there; patch set uploaded; this
will now need a few more reviewers.

[waffles, 2016-10-21 17:59:23]

> Does the code in ChromeContentClient::FindMostRecentPlugin also have to
change?

Not for Windows, but good point for other platforms. Actually, this change in
behavior enables us to make many simplifications there; patch set uploaded; this
will now need a few more reviewers.

[waffles, 2016-10-21 18:00:18]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 18:01:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 18:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 18:05:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Will Harris, 2016-10-21 20:05:49]

Yes, this does simplify things somewhat!

https://codereview.chromium.org/2434103005/diff/40001/base/files/file_util.h
File base/files/file_util.h (left):

https://codereview.chromium.org/2434103005/diff/40001/base/files/file_util.h#...
base/files/file_util.h:300: BASE_EXPORT bool IsOnNetworkDrive(const
base::FilePath& path);
file_util_unittest.cc probably needs updating if this is being removed.

[waffles, 2016-10-21 21:07:25]

https://codereview.chromium.org/2434103005/diff/40001/base/files/file_util.h
File base/files/file_util.h (left):

https://codereview.chromium.org/2434103005/diff/40001/base/files/file_util.h#...
base/files/file_util.h:300: BASE_EXPORT bool IsOnNetworkDrive(const
base::FilePath& path);
On 2016/10/21 20:05:48, Will Harris wrote:
> file_util_unittest.cc probably needs updating if this is being removed.

Done.

[waffles, 2016-10-21 21:07:59]

Description was changed from

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
==========

to

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
==========

[waffles, 2016-10-21 21:07:59]

waffles@chromium.org changed reviewers:
+ danakj@chromium.org, jochen@chromium.org

[Will Harris, 2016-10-21 21:12:10]

lgtm for the files I'm owner on which I don't think is any, but the approach
looks fine. I wonder how much TESTing we need to do here given it's
significantly less complex so less risk. Perhaps just a run of a few of the
cases in the main testing doc.

[waffles, 2016-10-21 21:16:24]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-10-21 21:17:47]

Description was changed from

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
==========

to

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from
https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3...
==========

[danakj, 2016-10-21 22:02:36]

deleting code LGTM

[commit-bot: I haz the power, 2016-10-21 23:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:20:14]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-24 07:26:19]

lgtm

[waffles, 2016-10-27 20:40:47]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:42:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[waffles, 2016-10-27 22:47:29]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:48:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:25:28]

Description was changed from

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from
https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3...
==========

to

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from
https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3...
==========

[commit-bot: I haz the power, 2016-10-27 23:25:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-27 23:29:19]

Description was changed from

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from
https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3...
==========

to

==========
Do not replace up-to-date System Flash with Component Flash.

BUG=656058
TEST=Cases 1, 3, 5 from
https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3...

Committed: https://crrev.com/151a7690b7312bed56784b8b953cce11e03a1085
Cr-Commit-Position: refs/heads/master@{#428205}
==========

[commit-bot: I haz the power, 2016-10-27 23:29:21]

Patchset 4 (id:??) landed as
https://crrev.com/151a7690b7312bed56784b8b953cce11e03a1085
Cr-Commit-Position: refs/heads/master@{#428205}