Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2463753003: Changes ScreenMusDelegate::GetWindowAtScreenPoint to return aura::Window (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes ScreenMusDelegate::GetWindowAtScreenPoint to return aura::Window This way I can use it with both mus and aura-mus. BUG=659155 TEST=none R=erg@chromium.org Committed: https://crrev.com/4cfb35a9796c4f49b2d608723242809081240fe6 Cr-Commit-Position: refs/heads/master@{#428824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M ui/views/mus/screen_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M ui/views/mus/screen_mus_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/test_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 3 chunks +24 lines, -9 lines 0 comments Download
M ui/views/mus/window_manager_connection_unittest.cc View 5 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 1 month ago (2016-10-31 18:24:41 UTC) #1
Elliot Glaysher
lgtm
4 years, 1 month ago (2016-10-31 19:04:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463753003/1
4 years, 1 month ago (2016-10-31 20:06:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 21:36:18 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:38:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cfb35a9796c4f49b2d608723242809081240fe6
Cr-Commit-Position: refs/heads/master@{#428824}

Powered by Google App Engine
This is Rietveld 408576698