VM: Enable branch merging of isnan, isinf.

VM: Enable branch merging of isnan, isinf.

More general ComparisonInstr by introducing TemplateComparison.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/b1dfa2aee15b4617032b927cd95d97f85c82dd6f

[Florian Schneider, 2016-10-30 15:54:45]

Description was changed from

==========
VM: Enable branch merging of isnan, isinf.

More general ComparisonInstr by introducing TemplateComparison.
==========

to

==========
VM: Enable branch merging of isnan, isinf.

More general ComparisonInstr by introducing TemplateComparison.
==========

[Florian Schneider, 2016-10-30 15:54:45]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2016-10-31 17:28:15]

lgtm w/ nits

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/branch_optim...
File runtime/vm/branch_optimizer.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/branch_optim...
runtime/vm/branch_optimizer.cc:47: if (comparison->InputCount() != 2) return
false;
Please use {}

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3026: kind,
weird indent

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.h:2419: class PureComparison: public
ComparisonInstr {
missing space before colon.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.h:2427: explicit PureComparison(TokenPosition
token_pos,
explicit not needed.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2234: if (!isnan(v)) pc++;
Please use {}

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2241: if (!isinf(v)) pc++;
ditto

[Florian Schneider, 2016-10-31 18:48:17]

Thanks!

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/branch_optim...
File runtime/vm/branch_optimizer.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/branch_optim...
runtime/vm/branch_optimizer.cc:47: if (comparison->InputCount() != 2) return
false;
On 2016/10/31 17:28:14, zra wrote:
> Please use {}

Done.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3026: kind,
On 2016/10/31 17:28:14, zra wrote:
> weird indent

Done.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.h:2419: class PureComparison: public
ComparisonInstr {
On 2016/10/31 17:28:15, zra wrote:
> missing space before colon.

Done.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.h:2427: explicit PureComparison(TokenPosition
token_pos,
On 2016/10/31 17:28:14, zra wrote:
> explicit not needed.

Done.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2234: if (!isnan(v)) pc++;
On 2016/10/31 17:28:15, zra wrote:
> Please use {}

Done.

https://codereview.chromium.org/2463593002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2241: if (!isinf(v)) pc++;
On 2016/10/31 17:28:15, zra wrote:
> ditto

Done.

[Florian Schneider, 2016-10-31 19:21:19]

Description was changed from

==========
VM: Enable branch merging of isnan, isinf.

More general ComparisonInstr by introducing TemplateComparison.
==========

to

==========
VM: Enable branch merging of isnan, isinf.

More general ComparisonInstr by introducing TemplateComparison.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b1dfa2aee15b4617032b927cd95d97f85c82dd6f
==========

[Florian Schneider, 2016-10-31 19:21:20]

Committed patchset #3 (id:40001) manually as
b1dfa2aee15b4617032b927cd95d97f85c82dd6f (presubmit successful).