VM: Enable branch merging of isnan, isinf.

runtime/vm/intermediate_language_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_DBC.
 #if defined(TARGET_ARCH_DBC)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/cpu.h"
@@ skipping 1631 matching lines @@
   switch (op_kind()) {
     case Token::kADD: __ DAdd(result, left, right); break;
     case Token::kSUB: __ DSub(result, left, right); break;
     case Token::kMUL: __ DMul(result, left, right); break;
     case Token::kDIV: __ DDiv(result, left, right); break;
     default: UNREACHABLE();
   }
 }
 
 
+Condition DoubleTestOpInstr::EmitComparisonCode(FlowGraphCompiler* compiler,
+                                                BranchLabels labels) {
+  UNREACHABLE();
+  return Condition();
+}
+
+
+void DoubleTestOpInstr::EmitBranchCode(FlowGraphCompiler* compiler,
+                                       BranchInstr* branch) {
+  ASSERT(compiler->is_optimizing());
+  BranchLabels labels = compiler->CreateBranchLabels(branch);
+  const Register value = locs()->in(0).reg();
+  switch (op_kind()) {
+    case MethodRecognizer::kDouble_getIsNaN:
+      __ DoubleIsNaN(value);
+      break;
+    case MethodRecognizer::kDouble_getIsInfinite:
+      __ DoubleIsInfinite(value);
+      break;
+    default:
+      UNREACHABLE();
+  }
+  const bool is_negated = kind() != Token::kEQ;
+  EmitBranchOnCondition(
+      compiler, is_negated ? NEXT_IS_FALSE : NEXT_IS_TRUE, labels);
+}
+
+
 EMIT_NATIVE_CODE(DoubleTestOp, 1, Location::RequiresRegister()) {
   ASSERT(compiler->is_optimizing());
   const Register value = locs()->in(0).reg();
   const Register result = locs()->out(0).reg();
+  const bool is_negated = kind() != Token::kEQ;
+  __ LoadConstant(result, is_negated ? Bool::True() : Bool::False());
   switch (op_kind()) {
     case MethodRecognizer::kDouble_getIsNaN:
-      __ DoubleIsNaN(result, value);
+      __ DoubleIsNaN(value);
       break;
     case MethodRecognizer::kDouble_getIsInfinite:
-      __ DoubleIsInfinite(result, value);
+      __ DoubleIsInfinite(value);
       break;
     default:
       UNREACHABLE();
   }
+  __ LoadConstant(result, is_negated ? Bool::False() : Bool::True());
 }
 
 
 EMIT_NATIVE_CODE(UnaryDoubleOp, 1, Location::RequiresRegister()) {
   const Register value = locs()->in(0).reg();
   const Register result = locs()->out(0).reg();
   __ DNeg(result, value);
 }
 
 
@@ skipping 149 matching lines @@
     condition = NEXT_IS_FALSE;
     comparison = FlipCondition(kind);
   }
   __ Emit(Bytecode::Encode(OpcodeForSmiCondition(comparison), left, right));
   return condition;
 }
 
 
 static Condition EmitDoubleComparisonOp(FlowGraphCompiler* compiler,
                                         LocationSummary* locs,
-                                        Token::Kind kind,
-                                        BranchLabels labels) {
+                                        Token::Kind kind) {
   const Register left = locs->in(0).reg();
   const Register right = locs->in(1).reg();
   Token::Kind comparison = kind;
   // For double comparisons we can't flip the condition like with smi
   // comparisons because of NaN which will compare false for all except !=
   // operations.
   // TODO(fschneider): Change the block order instead in DBC so that the
   // false block in always the fall-through block.
   Condition condition = NEXT_IS_TRUE;
   __ Emit(Bytecode::Encode(OpcodeForDoubleCondition(comparison), left, right));
   return condition;
 }
 
 
 Condition EqualityCompareInstr::EmitComparisonCode(FlowGraphCompiler* compiler,
                                                    BranchLabels labels) {
   if (operation_cid() == kSmiCid) {
     return EmitSmiComparisonOp(compiler, locs(), kind(), labels);
   } else {
     ASSERT(operation_cid() == kDoubleCid);
-    return EmitDoubleComparisonOp(compiler, locs(), kind(), labels);
+    return EmitDoubleComparisonOp(compiler, locs(), kind());
   }
 }
 
 
 EMIT_NATIVE_CODE(EqualityCompare, 2, Location::RequiresRegister()) {
   ASSERT(compiler->is_optimizing());
   ASSERT((kind() == Token::kEQ) || (kind() == Token::kNE));
   Label is_true, is_false;
   // These labels are not used. They are arranged so that EmitComparisonCode
   // emits a test that executes the following instruction when the test
@@ skipping 15 matching lines @@
   EmitBranchOnCondition(compiler, true_condition, labels);
 }
 
 
 Condition RelationalOpInstr::EmitComparisonCode(FlowGraphCompiler* compiler,
                                                 BranchLabels labels) {
   if (operation_cid() == kSmiCid) {
     return EmitSmiComparisonOp(compiler, locs(), kind(), labels);
   } else {
     ASSERT(operation_cid() == kDoubleCid);
-    return EmitDoubleComparisonOp(compiler, locs(), kind(), labels);
+    return EmitDoubleComparisonOp(compiler, locs(), kind());
   }
 }
 
 
 EMIT_NATIVE_CODE(RelationalOp, 2, Location::RequiresRegister()) {
   ASSERT(compiler->is_optimizing());
   Label is_true, is_false;
   BranchLabels labels = { &is_true, &is_false, &is_false };
   const Register result = locs()->out(0).reg();
   __ LoadConstant(result, Bool::False());
@@ skipping 25 matching lines @@
   __ IfULe(length, index);
   compiler->EmitDeopt(deopt_id(),
                       ICData::kDeoptCheckArrayBound,
                       (generalized_ ? ICData::kGeneralized : 0) |
                       (licm_hoisted_ ? ICData::kHoisted : 0));
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_DBC