Chromium Code Reviews| Index: chrome/browser/permissions/permission_uma_util.h |
| diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h |
| index f56e40d96c5b0393bcdb6ce0b8b4c2e7156d8c56..e4943a8e9a357d0ae6695b3271a78fe0851aa986 100644 |
| --- a/chrome/browser/permissions/permission_uma_util.h |
| +++ b/chrome/browser/permissions/permission_uma_util.h |
| @@ -9,6 +9,7 @@ |
| #include "base/logging.h" |
| #include "base/macros.h" |
| +#include "chrome/browser/permissions/permission_request.h" |
| #include "chrome/browser/permissions/permission_util.h" |
| enum class PermissionRequestGestureType; |
| @@ -126,6 +127,13 @@ class PermissionUmaUtil { |
| static void PermissionPromptShown( |
| const std::vector<PermissionRequest*>& requests); |
| + // Records the request type and gesture type for a shown prompt. Defined |
| + // separately as Android must call this method explicitly until the |
| + // PermissionRequestManager refactoring is completed. |
| + static void RecordPermissionPromptTypeAndGesture( |
|
benwells
2016/11/02 06:39:35
Are you planning to add analogs for PermissionProm
dominickn
2016/11/03 02:18:21
Oh crud, they're recorded separately too. This is
|
| + PermissionRequestType request_type, |
| + PermissionRequestGestureType gesture_type); |
| + |
| // The following two functions can be combined with the PermissionPromptShown |
| // metrics to calculate accept, deny and ignore rates. |
| // Note that for coalesced permission bubbles, PermissionPromptAccepted will |