Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6447)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2463393003: Record permission prompt gesture metrics on Android. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index b4dae09ec9c4070f4c72ec96544f6e9af9855575..0d049d813dbf076c47924de1d48c95c97ea8633a 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -371,10 +371,8 @@ void PermissionUmaUtil::PermissionPromptShown(
permission_gesture_type = requests[0]->GetGestureType();
}
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptShown, permission_prompt_type);
- PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
- kPermissionsPromptShownGesture, kPermissionsPromptShownNoGesture,
- permission_gesture_type, permission_prompt_type);
+ RecordPermissionPromptTypeAndGesture(permission_prompt_type,
+ permission_gesture_type);
UMA_HISTOGRAM_ENUMERATION(
kPermissionsPromptRequestsPerPrompt,
@@ -389,6 +387,15 @@ void PermissionUmaUtil::PermissionPromptShown(
}
}
+void PermissionUmaUtil::RecordPermissionPromptTypeAndGesture(
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type) {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptShown, request_type);
+ PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
+ kPermissionsPromptShownGesture, kPermissionsPromptShownNoGesture,
+ gesture_type, request_type);
+}
+
void PermissionUmaUtil::PermissionPromptAccepted(
const std::vector<PermissionRequest*>& requests,
const std::vector<bool>& accept_states) {

Powered by Google App Engine
This is Rietveld 408576698