Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2463383002: Fullscreen Notifications: Fix crash if delegate is NULL (Closed)

Created:
4 years, 1 month ago by dewittj
Modified:
4 years, 1 month ago
Reviewers:
bmalcolm
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. Review-Url: https://codereview.chromium.org/2459263004 Cr-Commit-Position: refs/heads/master@{#428825} (cherry picked from commit b58f87810fac6a4d5ef606032a35ed8e8b179bd2) Committed: https://chromium.googlesource.com/chromium/src/+/3bd6317c8d9449690991c07ff4f1957449d70fee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/notifications/fullscreen_notification_blocker.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
4 years, 1 month ago (2016-11-01 15:48:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bd6317c8d9449690991c07ff4f1957449d70fee.

Powered by Google App Engine
This is Rietveld 408576698