Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2459263004:
Fullscreen Notifications: Fix crash if delegate is NULL (Closed)
DescriptionFullscreen Notifications: Fix crash if delegate is NULL
Notification Delegates should never be NULL but it is not enforced with
a DCHECK, so of course there is a delegate that is null (for the ChromeOS
Battery notification). So fix the logic that never checks the delegate's
validity in FullscreenNotificationBlocker.
R=bmalcolm@chromium.org
BUG=660889
TEST=have a fullscreen app window and drain the battery
below the warning level.
Committed: https://crrev.com/b58f87810fac6a4d5ef606032a35ed8e8b179bd2
Cr-Commit-Position: refs/heads/master@{#428825}
Patch Set 1 #Patch Set 2 : remove braces. #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by dewittj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL, thanks!
The CQ bit was checked by dewittj@chromium.org to run a CQ dry run
lgtm LGTM Thanks. I was getting ready to do this, but was still getting my system set up. :-)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
if you have a ChromeOS build that is close to ready I'd appreciate a manual test, otherwise I'll start one from scratch
Alas I don't
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tested manually with chrome://device-emulator
Description was changed from ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 ========== to ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. ==========
The CQ bit was checked by dewittj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. ========== to ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. ========== to ========== Fullscreen Notifications: Fix crash if delegate is NULL Notification Delegates should never be NULL but it is not enforced with a DCHECK, so of course there is a delegate that is null (for the ChromeOS Battery notification). So fix the logic that never checks the delegate's validity in FullscreenNotificationBlocker. R=bmalcolm@chromium.org BUG=660889 TEST=have a fullscreen app window and drain the battery below the warning level. Committed: https://crrev.com/b58f87810fac6a4d5ef606032a35ed8e8b179bd2 Cr-Commit-Position: refs/heads/master@{#428825} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b58f87810fac6a4d5ef606032a35ed8e8b179bd2 Cr-Commit-Position: refs/heads/master@{#428825} |
