Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2463353002: [Interpreter] Remove unused --ignition-eager flag. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove unused --ignition-eager flag. BUG=v8:4280 Committed: https://crrev.com/ea5d4c1525678f25bca492781148ac481ce9cb19 Cr-Commit-Position: refs/heads/master@{#40697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
rmcilroy
Oral, thanks.
4 years, 1 month ago (2016-11-01 16:26:52 UTC) #6
rmcilroy
On 2016/11/01 16:26:52, rmcilroy (OOO - slow) wrote: > Oral, thanks. Autocomplete fail, meant PTAL....
4 years, 1 month ago (2016-11-01 16:27:29 UTC) #7
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-02 09:25:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463353002/1
4 years, 1 month ago (2016-11-02 09:35:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27656)
4 years, 1 month ago (2016-11-02 09:39:55 UTC) #12
rmcilroy
Marja, could you take a look at parser/ please
4 years, 1 month ago (2016-11-02 10:57:31 UTC) #14
marja
parser lgtm
4 years, 1 month ago (2016-11-02 10:59:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463353002/1
4 years, 1 month ago (2016-11-02 11:14:45 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 11:17:09 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:14 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea5d4c1525678f25bca492781148ac481ce9cb19
Cr-Commit-Position: refs/heads/master@{#40697}

Powered by Google App Engine
This is Rietveld 408576698