Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: test/cctest/test-parsing.cc

Issue 2463353002: [Interpreter] Remove unused --ignition-eager flag. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index f097505d76e8cb7683594fc77da5c539f4955f37..f32714d66232b37fe35ff641dcfccc19fc1aadfe 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -218,7 +218,7 @@ class ScriptResource : public v8::String::ExternalOneByteStringResource {
TEST(UsingCachedData) {
// Producing cached parser data while parsing eagerly is not supported.
- if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
+ if (!i::FLAG_lazy) return;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope handles(isolate);
@@ -271,7 +271,7 @@ TEST(UsingCachedData) {
TEST(PreparseFunctionDataIsUsed) {
// Producing cached parser data while parsing eagerly is not supported.
- if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
+ if (!i::FLAG_lazy) return;
// This tests that we actually do use the function data generated by the
// preparser.
@@ -462,7 +462,7 @@ TEST(RegressChromium62639) {
TEST(Regress928) {
// Test only applies when lazy parsing.
- if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
+ if (!i::FLAG_lazy) return;
i::FLAG_min_preparse_length = 0;
// Tests that the first non-toplevel function is not included in the preparse
@@ -3147,7 +3147,7 @@ TEST(FuncNameInferrerEscaped) {
TEST(RegressionLazyFunctionWithErrorWithArg) {
// Test only applies when lazy parsing.
- if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
+ if (!i::FLAG_lazy) return;
// The bug occurred when a lazy function had an error which requires a
// parameter (such as "unknown label" here). The error message was processed
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698