Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 246333006: Implement new bookmark app icon generation. (Closed)

Created:
6 years, 8 months ago by calamity
Modified:
6 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement new bookmark app icon generation. This CL changes the generation of bookmark apps to create an icon that consists of the favicon's dominant color as a background with the first letter of the app's domain painted over it. The letter is either black or white depending on the luminance of the background. This CL also turns on generation of 2x icons for 32 and 48 px icons. BUG=315632 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269745

Patch Set 1 : #

Total comments: 2

Patch Set 2 : use a CanvasImageSource for the image to work with Mac #

Patch Set 3 : rebase, platform-specific font selection #

Patch Set 4 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -113 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper.cc View 1 2 3 4 chunks +111 lines, -85 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper_unittest.cc View 1 2 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
calamity
6 years, 8 months ago (2014-04-24 03:22:15 UTC) #1
benwells
lgtm https://codereview.chromium.org/246333006/diff/40001/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (right): https://codereview.chromium.org/246333006/diff/40001/chrome/browser/extensions/bookmark_app_helper.cc#newcode240 chrome/browser/extensions/bookmark_app_helper.cc:240: // Also generate the 2x resource for this ...
6 years, 8 months ago (2014-04-24 03:35:57 UTC) #2
calamity
https://codereview.chromium.org/246333006/diff/40001/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (right): https://codereview.chromium.org/246333006/diff/40001/chrome/browser/extensions/bookmark_app_helper.cc#newcode240 chrome/browser/extensions/bookmark_app_helper.cc:240: // Also generate the 2x resource for this size. ...
6 years, 8 months ago (2014-04-24 04:28:39 UTC) #3
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 8 months ago (2014-04-24 04:32:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/246333006/40001
6 years, 8 months ago (2014-04-24 05:02:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 08:24:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-24 08:24:57 UTC) #7
calamity
*sigh* This is failing because Mac requires a valid font name or it crashes. I ...
6 years, 7 months ago (2014-04-29 11:04:21 UTC) #8
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 7 months ago (2014-05-12 01:26:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/246333006/100001
6 years, 7 months ago (2014-05-12 01:26:21 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 06:21:46 UTC) #11
Message was sent while issue was closed.
Change committed as 269745

Powered by Google App Engine
This is Rietveld 408576698