Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5681)

Unified Diff: chrome/browser/extensions/bookmark_app_helper.h

Issue 246333006: Implement new bookmark app icon generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/bookmark_app_helper.h
diff --git a/chrome/browser/extensions/bookmark_app_helper.h b/chrome/browser/extensions/bookmark_app_helper.h
index d6754df4c9264ba104ab80c1100678374741c47f..b0cb661fbd0a11226fbdbfd8a140e2eaeec1deda 100644
--- a/chrome/browser/extensions/bookmark_app_helper.h
+++ b/chrome/browser/extensions/bookmark_app_helper.h
@@ -52,11 +52,12 @@ class BookmarkAppHelper : public content::NotificationObserver {
const std::set<int>& sizes);
// Adds a square container icon of |output_size| pixels to |bitmaps| by
- // centering the biggest smaller icon in |bitmaps| and drawing a rounded
- // rectangle with strip of the that icon's dominant color at the bottom.
+ // drawing the given |letter| into a rounded background of |color|.
// Does nothing if an icon of |output_size| already exists in |bitmaps|.
- static void GenerateContainerIcon(std::map<int, SkBitmap>* bitmaps,
- int output_size);
+ static void GenerateIcon(std::map<int, SkBitmap>* bitmaps,
+ int output_size,
+ SkColor color,
+ char letter);
// Begins the asynchronous bookmark app creation.
void Create(const CreateBookmarkAppCallback& callback);
« no previous file with comments | « no previous file | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698