Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659
Committed: https://crrev.com/f68abde2798e2713e39b6911d68db0f219ae50f2
Cr-Commit-Position: refs/heads/master@{#429175}

[rwlbuis, 2016-11-01 18:02:20]

Description was changed from

==========
JSON WIP

BUG=
==========

to

==========
JSON WIP

BUG=602659
==========

[rwlbuis, 2016-11-01 18:04:34]

Description was changed from

==========
JSON WIP

BUG=602659
==========

to

==========
Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659
==========

[rwlbuis, 2016-11-01 18:06:27]

rob.buis@samsung.com changed reviewers:
+ rouslan@chromium.org

[rwlbuis, 2016-11-01 18:06:27]

PTAL.

Note that with or without this patch, passing some Objects like Sets or Maps
will not throw an exception and end up with
"{}". Not sure if that is the desired behavior.

[please use gerrit instead, 2016-11-01 18:54:35]

lgtm

On 2016/11/01 18:06:27, rwlbuis wrote:
> Note that with or without this patch, passing some Objects like Sets or Maps
> will not throw an exception and end up with
> "{}". Not sure if that is the desired behavior.

That's fine.

[rwlbuis, 2016-11-01 19:07:40]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-01 19:08:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:44:13]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rwlbuis, 2016-11-01 21:52:47]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-01 21:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 01:18:28]

Description was changed from

==========
Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659
==========

to

==========
Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659
==========

[commit-bot: I haz the power, 2016-11-02 01:18:29]

Committed patchset #2 (id:20001)

[haraken, 2016-11-02 01:19:00]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-11-02 01:19:01]

V8 API usage LGTM with a comment.

https://codereview.chromium.org/2463203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2463203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:378: if
(value.IsEmpty()) {

v8::Local<v8::String> value;
if (!v8::JSON::Stringify(...).To(&value)) {
  exceptionState.throwTypeError();
  return;
}
...

Also Blink prefers a fully qualified variable name.

paymentMethodData => paymentMethodDataVector
pmd => paymentMethodData

[commit-bot: I haz the power, 2016-11-02 01:19:48]

Description was changed from

==========
Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659
==========

to

==========
Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659

Committed: https://crrev.com/f68abde2798e2713e39b6911d68db0f219ae50f2
Cr-Commit-Position: refs/heads/master@{#429175}
==========

[commit-bot: I haz the power, 2016-11-02 01:19:49]

Patchset 2 (id:??) landed as
https://crrev.com/f68abde2798e2713e39b6911d68db0f219ae50f2
Cr-Commit-Position: refs/heads/master@{#429175}

[rwlbuis, 2016-11-02 01:59:09]

On 2016/11/02 01:19:01, haraken wrote:
> V8 API usage LGTM with a comment.
> 
>
https://codereview.chromium.org/2463203002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):
> 
>
https://codereview.chromium.org/2463203002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:378: if
> (value.IsEmpty()) {
> 
> v8::Local<v8::String> value;
> if (!v8::JSON::Stringify(...).To(&value)) {
>   exceptionState.throwTypeError();
>   return;
> }
> ...

Ah, will have a look tomorrow. I just reused the existing code dealing with
JSON::Stringify in other places :)

> Also Blink prefers a fully qualified variable name.
> 
> paymentMethodData => paymentMethodDataVector
> pmd => paymentMethodData

Ok.