Use JSON::Stringify instead of JSONValue

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/JSONValuesForV8.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/V8StringResource.h"
 #include "bindings/modules/v8/V8PaymentDetails.h"
 #include "core/EventTypeNames.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/events/Event.h"
 #include "core/events/EventQueue.h"
 #include "core/frame/FrameOwner.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "modules/EventTargetModulesNames.h"
 #include "modules/payments/HTMLIFrameElementPayments.h"
@@ skipping 338 matching lines @@
 
   for (const auto& pmd : paymentMethodData) {
     if (pmd.supportedMethods().isEmpty()) {
       exceptionState.throwTypeError(
           "Must specify at least one payment method identifier");
       return;
     }
 
     String stringifiedData = "";
     if (pmd.hasData() && !pmd.data().isEmpty()) {
-      std::unique_ptr<JSONValue> value =
-          toJSONValue(pmd.data().context(), pmd.data().v8Value());
-      if (!value) {
+      if (!pmd.data().v8Value()->IsObject() ||
+          pmd.data().v8Value()->IsArray()) {
+        exceptionState.throwTypeError(
+            "Data should be a JSON-serializable object");
+        return;
+      }
+
+      v8::MaybeLocal<v8::String> value = v8::JSON::Stringify(
+          pmd.data().context(), pmd.data().v8Value().As<v8::Object>());
+      if (value.IsEmpty()) {

[haraken, 2016/11/02 01:19:01]

v8::Local<v8::String> value;
if (!v8::JSON::Stringify(...).To(&value)) {
  exceptionState.throwTypeError();
  return;
}
...

Also Blink prefers a fully qualified variable name.

paymentMethodData => paymentMethodDataVector
pmd => paymentMethodData

         exceptionState.throwTypeError(
             "Unable to parse payment method specific data");
         return;
       }
-      if (!value->isNull()) {
-        if (value->getType() != JSONValue::TypeObject) {
-          exceptionState.throwTypeError(
-              "Data should be a JSON-serializable object");
-          return;
-        }
-        stringifiedData = JSONObject::cast(value.get())->toJSONString();
-      }
+      stringifiedData = v8StringToWebCoreString<String>(value.ToLocalChecked(),
+                                                        DoNotExternalize);
     }
     methodData->append(
         PaymentRequest::MethodData(pmd.supportedMethods(), stringifiedData));
   }
 }
 
 String getSelectedShippingOption(const PaymentDetails& details) {
   String result;
   if (!details.hasShippingOptions())
     return result;
@@ skipping 457 matching lines @@
   m_completeTimer.stop();
   m_completeResolver.clear();
   m_showResolver.clear();
   m_abortResolver.clear();
   if (m_clientBinding.is_bound())
     m_clientBinding.Close();
   m_paymentProvider.reset();
 }
 
 }  // namespace blink