Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2463153003: Revert of [Extensions] Limit Extension WebUI (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
Reviewers:
Devlin, Dan Beam, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Limit Extension WebUI (patchset #6 id:140001 of https://codereview.chromium.org/2452773002/ ) Reason for revert: Suspect causing failure: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54207 Original issue's description: > [Extensions] Limit ExtensionWebUI > > The bookmark manager needs a WebUI controller in order to change the > transition type for links. However, right now, we're creating WebUI for > every single extension. > > Instead, *only* create WebUI for the bookmark manager. > > Note that the ExtensionWebUI class is currently used for both this WebUI > and for chrome url overrides, which are very separate concepts and > should be split up, but I'll save that for a later CL. > > BUG=659798 > > Committed: https://crrev.com/f9bc386d7f73366b45cb85848d27b4343facf45d > Cr-Commit-Position: refs/heads/master@{#428747} TBR=dbeam@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659798 Committed: https://crrev.com/17ec5af3f0f5ba7d0d5df76094001153f6dd45e7 Cr-Commit-Position: refs/heads/master@{#428766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M chrome/browser/extensions/extension_web_ui.h View 5 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xidachen
Created Revert of [Extensions] Limit Extension WebUI
4 years, 1 month ago (2016-10-31 19:21:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463153003/1
4 years, 1 month ago (2016-10-31 19:22:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 19:27:19 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17ec5af3f0f5ba7d0d5df76094001153f6dd45e7 Cr-Commit-Position: refs/heads/master@{#428766}
4 years, 1 month ago (2016-10-31 19:49:30 UTC) #7
Devlin
On 2016/10/31 19:49:30, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 1 month ago (2016-10-31 20:15:42 UTC) #8
sky
On 2016/10/31 20:15:42, Devlin wrote: > On 2016/10/31 19:49:30, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-10-31 20:51:58 UTC) #9
xidachen
4 years, 1 month ago (2016-10-31 21:16:30 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2459263005/ by xidachen@chromium.org.

The reason for reverting is: Not the cause of the original issue, but we should
keep an eye on the bots after this re-lands..

Powered by Google App Engine
This is Rietveld 408576698