Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: chrome/browser/extensions/extension_web_ui.h

Issue 2463153003: Revert of [Extensions] Limit Extension WebUI (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_web_ui.h
diff --git a/chrome/browser/extensions/extension_web_ui.h b/chrome/browser/extensions/extension_web_ui.h
index 79de7d13287e9fbefd2b9f86f73a59a0574bed0a..3a9dbd5a285e706f2891c772757610005c6811dc 100644
--- a/chrome/browser/extensions/extension_web_ui.h
+++ b/chrome/browser/extensions/extension_web_ui.h
@@ -8,7 +8,6 @@
#include <memory>
#include <string>
-#include "base/macros.h"
#include "chrome/common/extensions/chrome_manifest_url_handlers.h"
#include "components/favicon_base/favicon_callback.h"
#include "content/public/browser/web_ui_controller.h"
@@ -32,8 +31,6 @@
// the main tab contents area. For example, each extension can specify an
// "options_page", and that page is displayed in the tab contents area and is
// hosted by this class.
-// TODO(devlin): The above description has nothing to do with this class as far
-// as I can tell.
class ExtensionWebUI : public content::WebUIController {
public:
static const char kExtensionURLOverrides[];
@@ -42,15 +39,9 @@
~ExtensionWebUI() override;
- // Returns true if the given url requires WebUI bindings.
- static bool NeedsExtensionWebUI(content::BrowserContext* browser_context,
- const GURL& url);
+ virtual extensions::BookmarkManagerPrivateDragEventRouter*
+ bookmark_manager_private_drag_event_router();
- // TODO(devlin): The rest of this class is static methods dealing with
- // chrome url overrides (e.g. changing chrome://newtab to go to an extension-
- // provided new tab page). This should be in a separate class from the WebUI
- // controller for the bookmark manager, and the WebUI controller should be
- // renamed.
// BrowserURLHandler
static bool HandleChromeURLOverride(GURL* url,
content::BrowserContext* browser_context);
@@ -93,11 +84,6 @@
const GURL& page_url,
const favicon_base::FaviconResultsCallback& callback);
- extensions::BookmarkManagerPrivateDragEventRouter*
- bookmark_manager_private_drag_event_router() {
- return bookmark_manager_private_drag_event_router_.get();
- }
-
private:
// Unregister the specified override, and if it's the currently active one,
// ensure that something takes its place.
@@ -111,7 +97,8 @@
std::unique_ptr<extensions::BookmarkManagerPrivateDragEventRouter>
bookmark_manager_private_drag_event_router_;
- DISALLOW_COPY_AND_ASSIGN(ExtensionWebUI);
+ // The URL this WebUI was created for.
+ GURL url_;
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEB_UI_H_
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698