Fix direct dependencies in //media/cast/BUILD.gn.

Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for executables use //media to reach the sub-components, to avoid duplicate symbols in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839
Committed: https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e
Cr-Commit-Position: refs/heads/master@{#431043}

[Wez, 2016-10-29 21:24:17]

wez@chromium.org changed reviewers:
+ miu@chromium.org

[Wez, 2016-10-29 21:24:18]

Yuri, PTAL - this is sufficient to get gn check passing on //media/cast (see
crbug.com/609355) but as per crbug.com/530839 the config headers could probably
use a little extra TLC to arrange them more logically.

https://codereview.chromium.org/2462863002/diff/1/media/cast/cast_config.h
File media/cast/cast_config.h (right):

https://codereview.chromium.org/2462863002/diff/1/media/cast/cast_config.h#ne...
media/cast/cast_config.h:25: enum Codec {
As per crbug.com/530839, do these really belong here, or under an explicit
"defines" header under //media/cast/common?  (And should the common CastConfig
itself live there, too?)

https://codereview.chromium.org/2462863002/diff/1/media/cast/net/cast_transpo...
File media/cast/net/cast_transport_config.h (right):

https://codereview.chromium.org/2462863002/diff/1/media/cast/net/cast_transpo...
media/cast/net/cast_transport_config.h:18: #include
"media/cast/net/cast_transport_defines.h"
nit It was a little strange that this was cast_transport_config and contained
some enum defines, rather than them being in cast_transport_defines - perhaps
the intention was to distinguish cast-internal from "public" defines?

[miu, 2016-10-31 02:01:02]

The CQ bit was checked by miu@chromium.org

[miu, 2016-10-31 02:01:03]

lgtm

[commit-bot: I haz the power, 2016-10-31 02:01:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[miu, 2016-10-31 02:10:34]

https://codereview.chromium.org/2462863002/diff/1/media/cast/cast_config.h
File media/cast/cast_config.h (right):

https://codereview.chromium.org/2462863002/diff/1/media/cast/cast_config.h#ne...
media/cast/cast_config.h:25: enum Codec {
On 2016/10/29 21:24:18, Wez wrote:
> As per crbug.com/530839, do these really belong here, or under an explicit
> "defines" header under //media/cast/common?  (And should the common CastConfig
> itself live there, too?)

Not entirely sure. I wanted to plan all this out better in a project where we
refactor the code a bit to allow media/cast to be built as a standalone library.
So, I'm not sure if this would go in common/ ot a new public/ dir. TBD...

https://codereview.chromium.org/2462863002/diff/1/media/cast/net/cast_transpo...
File media/cast/net/cast_transport_config.h (right):

https://codereview.chromium.org/2462863002/diff/1/media/cast/net/cast_transpo...
media/cast/net/cast_transport_config.h:18: #include
"media/cast/net/cast_transport_defines.h"
On 2016/10/29 21:24:18, Wez wrote:
> nit It was a little strange that this was cast_transport_config and contained
> some enum defines, rather than them being in cast_transport_defines - perhaps
> the intention was to distinguish cast-internal from "public" defines?

A lot of things need to move around. The media/cast/net dir was created in haste
to solve the problem of build/link dependencies. Meaning, net/ code is allowed
to run in the browser or render process, but all other code must run only in the
render process. Instead, we should have followed the pattern of having separate
browser/, common/, and renderer/ dirs, IMHO.

[commit-bot: I haz the power, 2016-10-31 02:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 02:39:26]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Wez, 2016-11-09 19:39:32]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 19:40:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-11-09 20:42:33]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2016-11-09 20:42:42]

The CQ bit was checked by wez@chromium.org

[Wez, 2016-11-09 20:42:43]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2462863002/#ps40001
(title: "Depend on //media rather than //media/base, etc")

[commit-bot: I haz the power, 2016-11-09 20:43:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-11-09 20:44:57]

Description was changed from

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

BUG=609355, 530839
==========

to

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets
for executables use //media to reach the sub-components, to avoid duplicate
symbols in component builds, due to use of source_set for //media/*
subcomponents.

BUG=609355, 530839
==========

[Wez, 2016-11-09 20:49:31]

Description was changed from

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets
for executables use //media to reach the sub-components, to avoid duplicate
symbols in component builds, due to use of source_set for //media/*
subcomponents.

BUG=609355, 530839
==========

to

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for
executables use //media to reach the sub-components, to avoid duplicate symbols
in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839
==========

[commit-bot: I haz the power, 2016-11-09 21:57:00]

Description was changed from

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for
executables use //media to reach the sub-components, to avoid duplicate symbols
in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839
==========

to

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for
executables use //media to reach the sub-components, to avoid duplicate symbols
in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839
==========

[commit-bot: I haz the power, 2016-11-09 21:57:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 22:02:20]

Description was changed from

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for
executables use //media to reach the sub-components, to avoid duplicate symbols
in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839
==========

to

==========
Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for
executables use //media to reach the sub-components, to avoid duplicate symbols
in component builds, due to use of source_set for //media/* subcomponents.

BUG=609355, 530839

Committed: https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e
Cr-Commit-Position: refs/heads/master@{#431043}
==========

[commit-bot: I haz the power, 2016-11-09 22:02:21]

Patchset 3 (id:??) landed as
https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e
Cr-Commit-Position: refs/heads/master@{#431043}