Fix direct dependencies in //media/cast/BUILD.gn.

media/cast/net/cast_transport_config.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_
 #define MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/stl_util.h"
+#include "media/cast/cast_config.h"
 #include "media/cast/common/rtp_time.h"
 #include "media/cast/net/cast_transport_defines.h"

[Wez, 2016/10/29 21:24:18]

nit It was a little strange that this was cast_transport_config and contained
some enum defines, rather than them being in cast_transport_defines - perhaps
the intention was to distinguish cast-internal from "public" defines?

[miu, 2016/10/31 02:10:34]

A lot of things need to move around. The media/cast/net dir was created in haste
to solve the problem of build/link dependencies. Meaning, net/ code is allowed
to run in the browser or render process, but all other code must run only in the
render process. Instead, we should have followed the pattern of having separate
browser/, common/, and renderer/ dirs, IMHO.

 
 namespace media {
 namespace cast {
 
-enum Codec {
-  CODEC_UNKNOWN,
-  CODEC_AUDIO_OPUS,
-  CODEC_AUDIO_PCM16,
-  CODEC_AUDIO_AAC,
-  CODEC_AUDIO_REMOTE,
-  CODEC_VIDEO_FAKE,
-  CODEC_VIDEO_VP8,
-  CODEC_VIDEO_H264,
-  CODEC_VIDEO_REMOTE,
-  CODEC_LAST = CODEC_VIDEO_REMOTE
-};
-
-// Describes the content being transported over RTP streams.
-enum class RtpPayloadType {
-  UNKNOWN = -1,
-
-  // Cast Streaming will encode raw audio frames using one of its available
-  // codec implementations, and transport encoded data in the RTP stream.
-  FIRST = 96,
-  AUDIO_OPUS = 96,
-  AUDIO_AAC = 97,
-  AUDIO_PCM16 = 98,
-
-  // Audio frame data is not modified, and should be transported reliably and
-  // in-sequence. No assumptions about the data can be made.
-  REMOTE_AUDIO = 99,
-
-  AUDIO_LAST = REMOTE_AUDIO,
-
-  // Cast Streaming will encode raw video frames using one of its available
-  // codec implementations, and transport encoded data in the RTP stream.
-  VIDEO_VP8 = 100,
-  VIDEO_H264 = 101,
-
-  // Video frame data is not modified, and should be transported reliably and
-  // in-sequence. No assumptions about the data can be made.
-  REMOTE_VIDEO = 102,
-
-  LAST = REMOTE_VIDEO
-};
-
 struct CastTransportRtpConfig {
   CastTransportRtpConfig();
   ~CastTransportRtpConfig();
 
   // Identifier for the RTP stream.
   int32_t rtp_stream_id;
 
   // Identifier refering to this sender.
   uint32_t ssrc;
 
@@ skipping 147 matching lines @@
          lhs.ntp_fraction == rhs.ntp_fraction &&
          lhs.rtp_timestamp == rhs.rtp_timestamp &&
          lhs.send_packet_count == rhs.send_packet_count &&
          lhs.send_octet_count == rhs.send_octet_count;
 }
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_