Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2462713003: Offline Page Cache: do not save a snapshot of a page loaded from a snapshot. (Closed)

Created:
4 years, 1 month ago by carlosk
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Offline Page Cache: do not save a snapshot of a page loaded from a snapshot. Offline Page Cache was saving snapshots of pages being loaded from previously saved snapshots, which is unnecessary. This change fixes that by only enabling the saving if the loaded page is not an "offline" page itself. BUG=660106 Review-Url: https://codereview.chromium.org/2448143005 Cr-Commit-Position: refs/heads/master@{#428239} (cherry picked from commit ff2b583208f110e3217e5879a6681b3e1875f7bb) Committed: https://chromium.googlesource.com/chromium/src/+/55afac3f35ed774b0a1cd79985f495e158fc2da3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
carlosk
4 years, 1 month ago (2016-10-28 22:42:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55afac3f35ed774b0a1cd79985f495e158fc2da3.

Powered by Google App Engine
This is Rietveld 408576698