Offline Page Cache: do not save a sapshot of a page loaded from a snapshot.

Offline Page Cache: do not save a snapshot of a page loaded from a snapshot.

Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.

BUG=660106
Committed: https://crrev.com/ff2b583208f110e3217e5879a6681b3e1875f7bb
Cr-Commit-Position: refs/heads/master@{#428239}

[carlosk, 2016-10-27 19:28:02]

carlosk@chromium.org changed reviewers:
+ jianli@chromium.org

[carlosk, 2016-10-27 19:28:03]

jianli@: PTAL.

[carlosk, 2016-10-27 19:28:22]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 19:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:56:42]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-10-27 19:57:04]

drive-by: this lgtm but it would be wise to check for race conditions with the
interceptor (jianli already can figure this out most likely)

Also: spelling in the title and commit message

[carlosk, 2016-10-27 20:00:44]

Description was changed from

==========
Offline Page Cache: do not save a sapshot of a page loaded from a snapshot.

Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.

BUG=660106
==========

to

==========
Offline Page Cache: do not save a snapshot of a page loaded from a snapshot.

Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.

BUG=660106
==========

[dewittj, 2016-10-27 20:10:18]

dewittj@chromium.org changed reviewers:
+ dewittj@chromium.org

[dewittj, 2016-10-27 20:10:18]

race is not possible, I don't see a problem with this.

[jianli, 2016-10-28 01:05:10]

lgtm

[carlosk, 2016-10-28 01:08:58]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:09:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:09:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 02:10:58]

Description was changed from

==========
Offline Page Cache: do not save a snapshot of a page loaded from a snapshot.

Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.

BUG=660106
==========

to

==========
Offline Page Cache: do not save a snapshot of a page loaded from a snapshot.

Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.

BUG=660106

Committed: https://crrev.com/ff2b583208f110e3217e5879a6681b3e1875f7bb
Cr-Commit-Position: refs/heads/master@{#428239}
==========

[commit-bot: I haz the power, 2016-10-28 02:10:59]

Patchset 1 (id:??) landed as
https://crrev.com/ff2b583208f110e3217e5879a6681b3e1875f7bb
Cr-Commit-Position: refs/heads/master@{#428239}