Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2462413002: Reland of Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use NGLogicalRect instead of NGExclusion for exclusions. (patchset #1 id:1 of https://codereview.chromium.org/2467803002/ ) Reason for revert: Relanding on top of https://codereview.chromium.org/2466913002/ since that one wasn't the culprit for the webkit_tests failures on WebKit Win7 (dbg). Original issue's description: > Revert of Use NGLogicalRect instead of NGExclusion for exclusions. (patchset #5 id:110016 of https://codereview.chromium.org/2457013004/ ) > > Reason for revert: > Reverting to enable reverting of https://codereview.chromium.org/2458253002/ in https://codereview.chromium.org/2458253002/ due to merge conflicts. > > Please reland once the flakiness has been sorted out. > > Original issue's description: > > Use NGLogicalRect instead of NGExclusion to work with exclusions. > > > > This patch does the following: > > - Delete NGExclusion > > - Change the code to use NGLogicalRect to store exclusions > > - Make NGPhysicalConstraintSpace to own the list of exclusions through Vector<std::unique_ptr> > > - Introduce WRITING_MODE_IGNORED macros that can be used to annotate cases where the writing mode is inored > > > > BUG=635619 > > > > Committed: https://crrev.com/250a6979a3311cb8a39ca7d7f316353550362f86 > > Cr-Commit-Position: refs/heads/master@{#428907} > > TBR=cbiesinger@chromium.org,eae@chromium.org,ikilpatrick@chromium.org,dpranke@chromium.org,glebl@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=635619 > > Committed: https://crrev.com/3b41bfed7efb2d172f8a9706f09c0b793adda997 > Cr-Commit-Position: refs/heads/master@{#428971} TBR=cbiesinger@chromium.org,eae@chromium.org,ikilpatrick@chromium.org,dpranke@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 Committed: https://crrev.com/33a189c87461dcecd60c7090e98aeb4a8f923964 Cr-Commit-Position: refs/heads/master@{#428998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -143 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +15 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 5 chunks +42 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 8 chunks +59 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_macros.h View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h View 3 chunks +4 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Reland of Use NGLogicalRect instead of NGExclusion for exclusions.
4 years, 1 month ago (2016-11-01 14:26:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462413002/1
4 years, 1 month ago (2016-11-01 14:26:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 14:28:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/33a189c87461dcecd60c7090e98aeb4a8f923964 Cr-Commit-Position: refs/heads/master@{#428998}
4 years, 1 month ago (2016-11-01 14:30:01 UTC) #6
eae
4 years, 1 month ago (2016-11-01 16:28:32 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698