Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_units.cc

Issue 2462413002: Reland of Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_units.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_units.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units.cc b/third_party/WebKit/Source/core/layout/ng/ng_units.cc
index 5537f4b37d567414e58bb74a1b4396480b7bf67a..71e9f0b0dea3928c3ff3da73cc714cc119753bea 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_units.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_units.cc
@@ -26,6 +26,13 @@
bool NGLogicalRect::IsEmpty() const {
// TODO(layout-dev): equality check shouldn't allocate an object each time.
return *this == NGLogicalRect();
+}
+
+bool NGLogicalRect::IsContained(const NGLogicalRect& other) const {
+ return !(InlineEndOffset() <= other.InlineStartOffset() ||
+ BlockEndOffset() <= other.BlockStartOffset() ||
+ InlineStartOffset() >= other.InlineEndOffset() ||
+ BlockStartOffset() >= other.BlockEndOffset());
}
bool NGLogicalRect::operator==(const NGLogicalRect& other) const {
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_units.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698