Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2462163002: DevTools: [Persistence] tabs should not change order during reload (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

DevTools: [Persistence] tabs should not change order during reload During page reload, the network UISourceCodes are removed and then re-added. This results in bindings being removed and then re-added. However, currently we're not doing a good job maintaining the selected tab and the tab order - they're getting shuffled during this process. This patch fixes the behavior so that the reload does not mess tabs order. BUG=660596 R=dgozman Review-Url: https://codereview.chromium.org/2460513003 Cr-Commit-Position: refs/heads/master@{#428555} (cherry picked from commit 1a31eac72f8252705bac3cee5823d0ec92d8d857) Committed: https://chromium.googlesource.com/chromium/src/+/12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
lushnikov
4 years, 1 month ago (2016-10-31 19:27:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12ae86e1fe82dcbd440a34c7ea5ccc6e9a5e8529.

Powered by Google App Engine
This is Rietveld 408576698