DevTools: [Persistence] tabs should not change order during reload

DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman

Committed: https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857
Cr-Commit-Position: refs/heads/master@{#428555}

[lushnikov, 2016-10-28 00:13:05]

please, take a look

I'd like to merge this to m-55 as well

[lushnikov, 2016-10-28 00:24:02]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 00:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-10-28 00:50:23]

lgtm

[commit-bot: I haz the power, 2016-10-28 01:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:38:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-10-28 22:14:30]

https://codereview.chromium.org/2460513003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
(right):

https://codereview.chromium.org/2460513003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html:85:
dumpSourceFrame(fileSystemSourceFrame);
since after this change the actual selected file will be filesystemSourceFrame

[lushnikov, 2016-10-28 22:14:35]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-28 22:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2460513003/#ps20001
(title: "fix test")

[commit-bot: I haz the power, 2016-10-28 22:15:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-28 23:33:20]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-10-28 23:37:01]

Description was changed from

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=658089
R=dgozman
==========

to

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman
==========

[lushnikov, 2016-10-28 23:37:19]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:37:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 00:25:25]

Description was changed from

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman
==========

to

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman
==========

[commit-bot: I haz the power, 2016-10-29 00:25:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-29 00:44:35]

Description was changed from

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman
==========

to

==========
DevTools: [Persistence] tabs should not change order during reload

During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.

However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.

This patch fixes the behavior so that the reload does not mess tabs
order.

BUG=660596
R=dgozman

Committed: https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857
Cr-Commit-Position: refs/heads/master@{#428555}
==========

[commit-bot: I haz the power, 2016-10-29 00:44:36]

Patchset 2 (id:??) landed as
https://crrev.com/1a31eac72f8252705bac3cee5823d0ec92d8d857
Cr-Commit-Position: refs/heads/master@{#428555}