[Spec compat] form element pointer should be set iff no template element on the stack of open eleme…

[Spec compat] form element pointer should be set iff no template element on the stack of open elements

Before this CL, the form element pointer was set iff *template element was the owner element of the current node*, which is wrong.
After this CL, the form element pointer is set iff *template element is on the stack of open elements*, which follows the spec:

https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody
"Insert an HTML element for the token, and, if there is no template element on the stack of open elements, set the form element pointer to point to the element created."

BUG=660671
Committed: https://crrev.com/c69c00516d0b3092098439e7d2940005468dbf3b
Cr-Commit-Position: refs/heads/master@{#430573}

[kouhei (in TOK), 2016-11-01 03:45:12]

kouhei@chromium.org changed reviewers:
+ dominicc@chromium.org

[kaizhu256, 2016-11-03 01:23:35]

kaizhu256@gmail.com changed reviewers:
+ kaizhu256@gmail.com

[kaizhu256, 2016-11-03 01:23:36]

https://codereview.chromium.org/2462143003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/parser/form-in-template.html (right):

https://codereview.chromium.org/2462143003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/parser/form-in-template.html:5: let snippet
= '<a><form></form><div></div></a>';
the test-case can be generalized to
-  let snippet = '<a><form></form><div></div></a>';
+  let snippet = '<form></form><div></div>';

tested the generalized case to fail inside stable chrome's console:

      var snippet = '<form></form><div></div>';
      var templateTag = document.createElement('template');
      templateTag.innerHTML = snippet
      console.assert(templateTag.innerHTML === snippet, "Unexpected reparenting
shouldn't happen.");
      // output:
      // VM131:4 Assertion failed: Unexpected reparenting shouldn't happen.

[kouhei (in TOK), 2016-11-04 05:20:15]

dominicc: friendly ping

[kaizhu256, 2016-11-07 12:13:37]

On 2016/11/04 05:20:15, kouhei wrote:
> dominicc: friendly ping

yea, this a high priority bugfix for me, as it breaks something at work (since 2
weeks ago : )

[dominicc (has gone to gerrit), 2016-11-08 08:40:43]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-11-08 08:40:44]

lgtm

lgtm

Sorry I missed this. Nice test!

[commit-bot: I haz the power, 2016-11-08 08:41:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 11:03:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 11:05:13]

Description was changed from

==========
[Spec compat] form element pointer should be set iff no template element on the
stack of open elements

Before this CL, the form element pointer was set iff *template element was the
owner element of the current node*, which is wrong.
After this CL, the form element pointer is set iff *template element is on the
stack of open elements*, which follows the spec:

https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody
"Insert an HTML element for the token, and, if there is no template element on
the stack of open elements, set the form element pointer to point to the element
created."

BUG=660671
==========

to

==========
[Spec compat] form element pointer should be set iff no template element on the
stack of open elements

Before this CL, the form element pointer was set iff *template element was the
owner element of the current node*, which is wrong.
After this CL, the form element pointer is set iff *template element is on the
stack of open elements*, which follows the spec:

https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody
"Insert an HTML element for the token, and, if there is no template element on
the stack of open elements, set the form element pointer to point to the element
created."

BUG=660671

Committed: https://crrev.com/c69c00516d0b3092098439e7d2940005468dbf3b
Cr-Commit-Position: refs/heads/master@{#430573}
==========

[commit-bot: I haz the power, 2016-11-08 11:05:14]

Patchset 2 (id:??) landed as
https://crrev.com/c69c00516d0b3092098439e7d2940005468dbf3b
Cr-Commit-Position: refs/heads/master@{#430573}