third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp - Issue 2462143003: [Spec compat] form element pointer should be set iff no template element on the stack of open eleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

Issue 2462143003: [Spec compat] form element pointer should be set iff no template element on the stack of open eleme… (Closed)

Patch Set: mod the test case a bit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/parser/form-in-template.html ('K') | « third_party/WebKit/LayoutTests/fast/parser/form-in-template.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

index 3304c74ba11a7685ee032f54d15b7060f456ccf6..613f0e44e4c7a4a2301441c93df06e21cdf7efa7 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

@@ -676,7 +676,7 @@ void HTMLConstructionSite::insertHTMLFormElement(AtomicHTMLToken* token,

HTMLElement* element = createHTMLElement(token);

ASSERT(isHTMLFormElement(element));

HTMLFormElement* formElement = toHTMLFormElement(element);

- if (!ownerDocumentForCurrentNode().isTemplateDocument())

+ if (!openElements()->hasTemplateInHTMLScope())

m_form = formElement;

formElement->setDemoted(isDemoted);

attachLater(currentNode(), formElement);

« third_party/WebKit/LayoutTests/fast/parser/form-in-template.html ('K') | « third_party/WebKit/LayoutTests/fast/parser/form-in-template.html ('k') | no next file » | no next file with comments »