Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements.

Source/core/rendering/HitTestResult.cpp

Index: Source/core/rendering/HitTestResult.cpp
diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp
index cf5316427df867774fbe854bff10e323791591f5..4286f6636251f5c4777642092ad8e2949b921652 100644
--- a/Source/core/rendering/HitTestResult.cpp
+++ b/Source/core/rendering/HitTestResult.cpp
@@ -371,10 +371,10 @@ bool HitTestResult::isContentEditable() const
         return false;
 
     if (isHTMLTextAreaElement(*m_innerNonSharedNode))
-        return true;
+        return !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly();

[Yuta Kitamura, 2014/10/16 04:01:23]

nit: Since we know m_innerNodeSharedNode is non-null, it's
better to use a reference rather than a pointer, i.e.:

  !toHTMLFormControlElement(*m_innerNonSharedNode).isDisabledOrReadOnly()

nit: toHTMLTextAreaElement() may be slightly better than
toHTMLFormControlElement(), because it matches the type check
immediately before this line.

[AKVT, 2014/10/16 17:17:14]

Done. Thank you

 
     if (isHTMLInputElement(*m_innerNonSharedNode))
-        return toHTMLInputElement(*m_innerNonSharedNode).isTextField();
+        return !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly() && toHTMLInputElement(*m_innerNonSharedNode).isTextField();

[Yuta Kitamura, 2014/10/16 04:01:23]

nit: Doing the type cast twice for the same object sounds
a bit silly.

You can save the reference to HTMLInputElement in a local
variable, and then use it to grab the result, i.e.:

    HTMLInputElement& inputElement = toHTMLInputElement(*m_innerNonSharedNode);
    return inputElement.isDisabledOrReadOnly() && inputElement.isTextField();

[AKVT, 2014/10/16 17:17:14]

Done. Thank you

 
     return m_innerNonSharedNode->hasEditableStyle();
 }