Fixed unnecessary Paste Popup showing issue when long press on ReadOnly/Disabled elements.

Source/core/rendering/HitTestResult.cpp

 /*
  * Copyright (C) 2006, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 353 matching lines @@
 // FIXME: This function needs a better name and may belong in a different class. It's not
 // really isContentEditable(); it's more like needsEditingContextMenu(). In many ways, this
 // function would make more sense in the ContextMenu class, except that WebElementDictionary
 // hooks into it. Anyway, we should architect this better.
 bool HitTestResult::isContentEditable() const
 {
     if (!m_innerNonSharedNode)
         return false;
 
     if (isHTMLTextAreaElement(*m_innerNonSharedNode))
-        return true;
+        return !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly();

[Yuta Kitamura, 2014/10/16 04:01:23]

nit: Since we know m_innerNodeSharedNode is non-null, it's
better to use a reference rather than a pointer, i.e.:

  !toHTMLFormControlElement(*m_innerNonSharedNode).isDisabledOrReadOnly()

nit: toHTMLTextAreaElement() may be slightly better than
toHTMLFormControlElement(), because it matches the type check
immediately before this line.

[AKVT, 2014/10/16 17:17:14]

Done. Thank you

 
     if (isHTMLInputElement(*m_innerNonSharedNode))
-        return toHTMLInputElement(*m_innerNonSharedNode).isTextField();
+        return !toHTMLFormControlElement(m_innerNonSharedNode)->isDisabledOrReadOnly() && toHTMLInputElement(*m_innerNonSharedNode).isTextField();

[Yuta Kitamura, 2014/10/16 04:01:23]

nit: Doing the type cast twice for the same object sounds
a bit silly.

You can save the reference to HTMLInputElement in a local
variable, and then use it to grab the result, i.e.:

    HTMLInputElement& inputElement = toHTMLInputElement(*m_innerNonSharedNode);
    return inputElement.isDisabledOrReadOnly() && inputElement.isTextField();

[AKVT, 2014/10/16 17:17:14]

Done. Thank you

 
     return m_innerNonSharedNode->hasEditableStyle();
 }
 
 bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const HitTestRequest& request, const HitTestLocation& locationInContainer, const LayoutRect& rect)
 {
     // If it is not a rect-based hit test, this method has to be no-op.
     // Return false, so the hit test stops.
     if (!isRectBasedTest())
         return false;
@@ skipping 86 matching lines @@
 {
     for (Node* node = m_innerNode.get(); node; node = NodeRenderingTraversal::parent(node)) {
         if (node->isElementNode())
             return toElement(node);
     }
 
     return 0;
 }
 
 } // namespace blink