NQE: Store the current network quality in a single variable

NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network
quality in a single variable instead of 3 different
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
Committed: https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06
Cr-Commit-Position: refs/heads/master@{#430385}

[tbansal1, 2016-10-28 23:59:04]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-10-28 23:59:08]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-10-29 00:22:32]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2016-10-29 00:22:45]

Description was changed from

==========
NQE: Add more algos

BUG=
==========

to

==========
NQE: Cleanup

BUG=
==========

[tbansal1, 2016-10-29 00:23:09]

Description was changed from

==========
NQE: Cleanup

BUG=
==========

to

==========
NQE: Cleanup

BUG=649887
==========

[tbansal1, 2016-10-29 00:25:57]

Description was changed from

==========
NQE: Cleanup

BUG=649887
==========

to

==========
NQE: Cleanup

Store the estimates in a single variables

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

[tbansal1, 2016-10-29 00:26:02]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 00:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-10-29 00:28:00]

Description was changed from

==========
NQE: Cleanup

Store the estimates in a single variables

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

to

==========
NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network 
quality in a single variable instead of 3 different 
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

[tbansal1, 2016-10-29 00:28:22]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-10-29 00:28:22]

ryansturm: ptal. thanks

[commit-bot: I haz the power, 2016-10-29 01:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 01:43:10]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-10-31 19:22:11]

lgtm % a question/nit

https://codereview.chromium.org/2461833002/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2461833002/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:761: base::TimeDelta recent_http_rtt =
nqe::internal::InvalidRTT();
nit: Is this part necessary? If GetRecentHttpRTT returns true this will be set,
if it returns false, it will get set on line 763.

Side-note: this change is to support line 821, and is more or less changing
nothing else?

[tbansal1, 2016-10-31 21:34:51]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-10-31 21:34:51]

bengr: ptal. thanks.

https://codereview.chromium.org/2461833002/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2461833002/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:761: base::TimeDelta recent_http_rtt =
nqe::internal::InvalidRTT();
On 2016/10/31 19:22:10, Ryan Sturm wrote:
> nit: Is this part necessary? If GetRecentHttpRTT returns true this will be
set,
> if it returns false, it will get set on line 763.
> 
> Side-note: this change is to support line 821, and is more or less changing
> nothing else?

Done.

[tbansal1, 2016-10-31 21:34:58]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 22:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:47:55]

Dry run: This issue passed the CQ dry run.

[bengr, 2016-11-03 15:36:48]

lgtm

https://codereview.chromium.org/2461833002/diff/60001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2461833002/diff/60001/net/nqe/network_quality...
net/nqe/network_quality_estimator.h:694: // Current estimates of the network
quality.
estimates -> estimate?

[tbansal1, 2016-11-04 02:48:45]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 02:49:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:26:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbansal1, 2016-11-06 07:38:48]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 07:38:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 08:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 08:36:59]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-11-06 19:38:53]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-11-06 19:38:58]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-06 19:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 20:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 20:36:45]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-11-07 17:27:59]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-11-07 17:28:19]

https://codereview.chromium.org/2461833002/diff/60001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2461833002/diff/60001/net/nqe/network_quality...
net/nqe/network_quality_estimator.h:694: // Current estimates of the network
quality.
On 2016/11/03 15:36:48, bengr wrote:
> estimates -> estimate?

Done.

[commit-bot: I haz the power, 2016-11-07 17:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-11-07 18:09:37]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-11-07 18:25:16]

Patchset #5 (id:140001) has been deleted

[tbansal1, 2016-11-07 18:25:50]

Patchset #6 (id:180001) has been deleted

[tbansal1, 2016-11-07 19:49:16]

Patchset #5 (id:160001) has been deleted

[tbansal1, 2016-11-07 19:49:49]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:14:18]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-11-07 21:17:07]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-11-07 21:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org, bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2461833002/#ps200001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-07 21:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:50:52]

Description was changed from

==========
NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network 
quality in a single variable instead of 3 different 
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

to

==========
NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network 
quality in a single variable instead of 3 different 
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

[commit-bot: I haz the power, 2016-11-07 21:50:53]

Committed patchset #5 (id:200001)

[commit-bot: I haz the power, 2016-11-07 22:21:53]

Description was changed from

==========
NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network 
quality in a single variable instead of 3 different 
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887
==========

to

==========
NQE: Store the current network quality in a single variable

Network Quality Estimator (NQE): Store the current network
quality in a single variable instead of 3 different
variables.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=649887

Committed: https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06
Cr-Commit-Position: refs/heads/master@{#430385}
==========

[commit-bot: I haz the power, 2016-11-07 22:21:54]

Patchset 5 (id:??) landed as
https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06
Cr-Commit-Position: refs/heads/master@{#430385}