Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: net/nqe/network_quality_estimator.h

Issue 2461833002: NQE: Store the current network quality in a single variable (Closed)
Patch Set: ryansturm nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_ 5 #ifndef NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
6 #define NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_ 6 #define NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 const base::TimeDelta effective_connection_type_recomputation_interval_; 684 const base::TimeDelta effective_connection_type_recomputation_interval_;
685 685
686 // Time when the effective connection type was last computed. 686 // Time when the effective connection type was last computed.
687 base::TimeTicks last_effective_connection_type_computation_; 687 base::TimeTicks last_effective_connection_type_computation_;
688 688
689 // Number of RTT and bandwidth samples available when effective connection 689 // Number of RTT and bandwidth samples available when effective connection
690 // type was last recomputed. 690 // type was last recomputed.
691 size_t rtt_observations_size_at_last_ect_computation_; 691 size_t rtt_observations_size_at_last_ect_computation_;
692 size_t throughput_observations_size_at_last_ect_computation_; 692 size_t throughput_observations_size_at_last_ect_computation_;
693 693
694 // Current estimates of the HTTP RTT, transport RTT and downstream throughput 694 // Current estimates of the network quality.
bengr 2016/11/03 15:36:48 estimates -> estimate?
tbansal1 2016/11/07 17:28:19 Done.
695 // (in kilobits per second). 695 nqe::internal::NetworkQuality network_quality_;
696 base::TimeDelta http_rtt_;
697 base::TimeDelta transport_rtt_;
698 int32_t downstream_throughput_kbps_;
699 696
700 // Current effective connection type. It is updated on connection change 697 // Current effective connection type. It is updated on connection change
701 // events. It is also updated every time there is network traffic (provided 698 // events. It is also updated every time there is network traffic (provided
702 // the last computation was more than 699 // the last computation was more than
703 // |effective_connection_type_recomputation_interval_| ago). 700 // |effective_connection_type_recomputation_interval_| ago).
704 EffectiveConnectionType effective_connection_type_; 701 EffectiveConnectionType effective_connection_type_;
705 702
706 // Minimum and Maximum signal strength (in dbM) observed since last connection 703 // Minimum and Maximum signal strength (in dbM) observed since last connection
707 // change. Updated on connection change and main frame requests. 704 // change. Updated on connection change and main frame requests.
708 int32_t min_signal_strength_since_connection_change_; 705 int32_t min_signal_strength_since_connection_change_;
(...skipping 18 matching lines...) Expand all
727 base::ThreadChecker thread_checker_; 724 base::ThreadChecker thread_checker_;
728 725
729 base::WeakPtrFactory<NetworkQualityEstimator> weak_ptr_factory_; 726 base::WeakPtrFactory<NetworkQualityEstimator> weak_ptr_factory_;
730 727
731 DISALLOW_COPY_AND_ASSIGN(NetworkQualityEstimator); 728 DISALLOW_COPY_AND_ASSIGN(NetworkQualityEstimator);
732 }; 729 };
733 730
734 } // namespace net 731 } // namespace net
735 732
736 #endif // NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_ 733 #endif // NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
OLDNEW
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698