Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc

Issue 2461683002: Slice enum HttpResponseInfo::ConnectionInfo by QUIC version. (Closed)
Patch Set: Update recently introduced CONNECTION_INFO_QUIC occurrences. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
index 33c281fe753744f0a86bc67e88e5a1030c3af02c..be3764b48b2ec31945ce28e63eae17a3776418e8 100644
--- a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
@@ -51,7 +51,12 @@ void ProtocolPageLoadMetricsObserver::OnParseStart(
"PageLoad.Clients.Protocol.H2.ParseTiming.NavigationToParseStart",
timing.parse_start.value());
break;
- case net::HttpResponseInfo::CONNECTION_INFO_QUIC:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.ParseTiming.NavigationToParseStart",
timing.parse_start.value());
@@ -84,7 +89,12 @@ void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint(
"ParseStartToFirstContentfulPaint",
timing.first_contentful_paint.value() - timing.parse_start.value());
break;
- case net::HttpResponseInfo::CONNECTION_INFO_QUIC:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.PaintTiming."
"ParseStartToFirstContentfulPaint",
@@ -118,7 +128,12 @@ void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint(
"ParseStartToFirstMeaningfulPaint",
timing.first_meaningful_paint.value() - timing.parse_start.value());
break;
- case net::HttpResponseInfo::CONNECTION_INFO_QUIC:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.Experimental.PaintTiming."
"ParseStartToFirstMeaningfulPaint",
@@ -152,7 +167,12 @@ void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart(
"NavigationToDOMContentLoadedEventFired",
timing.dom_content_loaded_event_start.value());
break;
- case net::HttpResponseInfo::CONNECTION_INFO_QUIC:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.DocumentTiming."
"NavigationToDOMContentLoadedEventFired",
@@ -186,7 +206,12 @@ void ProtocolPageLoadMetricsObserver::OnLoadEventStart(
"NavigationToLoadEventFired",
timing.load_event_start.value());
break;
- case net::HttpResponseInfo::CONNECTION_INFO_QUIC:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
+ case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.DocumentTiming."
"NavigationToLoadEventFired",
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698