Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc

Issue 2461683002: Slice enum HttpResponseInfo::ConnectionInfo by QUIC version. (Closed)
Patch Set: Update recently introduced CONNECTION_INFO_QUIC occurrences. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h" 5 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h"
6 6
7 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 7 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
8 8
9 page_load_metrics::PageLoadMetricsObserver::ObservePolicy 9 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
10 ProtocolPageLoadMetricsObserver::OnStart( 10 ProtocolPageLoadMetricsObserver::OnStart(
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 case net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1: 44 case net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1:
45 PAGE_LOAD_HISTOGRAM( 45 PAGE_LOAD_HISTOGRAM(
46 "PageLoad.Clients.Protocol.H11.ParseTiming.NavigationToParseStart", 46 "PageLoad.Clients.Protocol.H11.ParseTiming.NavigationToParseStart",
47 timing.parse_start.value()); 47 timing.parse_start.value());
48 break; 48 break;
49 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: 49 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
50 PAGE_LOAD_HISTOGRAM( 50 PAGE_LOAD_HISTOGRAM(
51 "PageLoad.Clients.Protocol.H2.ParseTiming.NavigationToParseStart", 51 "PageLoad.Clients.Protocol.H2.ParseTiming.NavigationToParseStart",
52 timing.parse_start.value()); 52 timing.parse_start.value());
53 break; 53 break;
54 case net::HttpResponseInfo::CONNECTION_INFO_QUIC: 54 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
55 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
56 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
57 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
58 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
59 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
55 PAGE_LOAD_HISTOGRAM( 60 PAGE_LOAD_HISTOGRAM(
56 "PageLoad.Clients.Protocol.QUIC.ParseTiming.NavigationToParseStart", 61 "PageLoad.Clients.Protocol.QUIC.ParseTiming.NavigationToParseStart",
57 timing.parse_start.value()); 62 timing.parse_start.value());
58 break; 63 break;
59 } 64 }
60 } 65 }
61 66
62 void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint( 67 void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint(
63 const page_load_metrics::PageLoadTiming& timing, 68 const page_load_metrics::PageLoadTiming& timing,
64 const page_load_metrics::PageLoadExtraInfo& extra_info) { 69 const page_load_metrics::PageLoadExtraInfo& extra_info) {
(...skipping 12 matching lines...) Expand all
77 "PageLoad.Clients.Protocol.H11.PaintTiming." 82 "PageLoad.Clients.Protocol.H11.PaintTiming."
78 "ParseStartToFirstContentfulPaint", 83 "ParseStartToFirstContentfulPaint",
79 timing.first_contentful_paint.value() - timing.parse_start.value()); 84 timing.first_contentful_paint.value() - timing.parse_start.value());
80 break; 85 break;
81 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: 86 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
82 PAGE_LOAD_HISTOGRAM( 87 PAGE_LOAD_HISTOGRAM(
83 "PageLoad.Clients.Protocol.H2.PaintTiming." 88 "PageLoad.Clients.Protocol.H2.PaintTiming."
84 "ParseStartToFirstContentfulPaint", 89 "ParseStartToFirstContentfulPaint",
85 timing.first_contentful_paint.value() - timing.parse_start.value()); 90 timing.first_contentful_paint.value() - timing.parse_start.value());
86 break; 91 break;
87 case net::HttpResponseInfo::CONNECTION_INFO_QUIC: 92 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
93 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
94 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
95 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
96 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
97 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
88 PAGE_LOAD_HISTOGRAM( 98 PAGE_LOAD_HISTOGRAM(
89 "PageLoad.Clients.Protocol.QUIC.PaintTiming." 99 "PageLoad.Clients.Protocol.QUIC.PaintTiming."
90 "ParseStartToFirstContentfulPaint", 100 "ParseStartToFirstContentfulPaint",
91 timing.first_contentful_paint.value() - timing.parse_start.value()); 101 timing.first_contentful_paint.value() - timing.parse_start.value());
92 break; 102 break;
93 } 103 }
94 } 104 }
95 105
96 void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint( 106 void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint(
97 const page_load_metrics::PageLoadTiming& timing, 107 const page_load_metrics::PageLoadTiming& timing,
(...skipping 13 matching lines...) Expand all
111 "PageLoad.Clients.Protocol.H11.Experimental.PaintTiming." 121 "PageLoad.Clients.Protocol.H11.Experimental.PaintTiming."
112 "ParseStartToFirstMeaningfulPaint", 122 "ParseStartToFirstMeaningfulPaint",
113 timing.first_meaningful_paint.value() - timing.parse_start.value()); 123 timing.first_meaningful_paint.value() - timing.parse_start.value());
114 break; 124 break;
115 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: 125 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
116 PAGE_LOAD_HISTOGRAM( 126 PAGE_LOAD_HISTOGRAM(
117 "PageLoad.Clients.Protocol.H2.Experimental.PaintTiming." 127 "PageLoad.Clients.Protocol.H2.Experimental.PaintTiming."
118 "ParseStartToFirstMeaningfulPaint", 128 "ParseStartToFirstMeaningfulPaint",
119 timing.first_meaningful_paint.value() - timing.parse_start.value()); 129 timing.first_meaningful_paint.value() - timing.parse_start.value());
120 break; 130 break;
121 case net::HttpResponseInfo::CONNECTION_INFO_QUIC: 131 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
132 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
133 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
134 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
135 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
136 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
122 PAGE_LOAD_HISTOGRAM( 137 PAGE_LOAD_HISTOGRAM(
123 "PageLoad.Clients.Protocol.QUIC.Experimental.PaintTiming." 138 "PageLoad.Clients.Protocol.QUIC.Experimental.PaintTiming."
124 "ParseStartToFirstMeaningfulPaint", 139 "ParseStartToFirstMeaningfulPaint",
125 timing.first_meaningful_paint.value() - timing.parse_start.value()); 140 timing.first_meaningful_paint.value() - timing.parse_start.value());
126 break; 141 break;
127 } 142 }
128 } 143 }
129 144
130 void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart( 145 void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart(
131 const page_load_metrics::PageLoadTiming& timing, 146 const page_load_metrics::PageLoadTiming& timing,
(...skipping 13 matching lines...) Expand all
145 "PageLoad.Clients.Protocol.H11.DocumentTiming." 160 "PageLoad.Clients.Protocol.H11.DocumentTiming."
146 "NavigationToDOMContentLoadedEventFired", 161 "NavigationToDOMContentLoadedEventFired",
147 timing.dom_content_loaded_event_start.value()); 162 timing.dom_content_loaded_event_start.value());
148 break; 163 break;
149 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: 164 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
150 PAGE_LOAD_HISTOGRAM( 165 PAGE_LOAD_HISTOGRAM(
151 "PageLoad.Clients.Protocol.H2.DocumentTiming." 166 "PageLoad.Clients.Protocol.H2.DocumentTiming."
152 "NavigationToDOMContentLoadedEventFired", 167 "NavigationToDOMContentLoadedEventFired",
153 timing.dom_content_loaded_event_start.value()); 168 timing.dom_content_loaded_event_start.value());
154 break; 169 break;
155 case net::HttpResponseInfo::CONNECTION_INFO_QUIC: 170 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
171 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
172 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
173 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
174 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
175 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
156 PAGE_LOAD_HISTOGRAM( 176 PAGE_LOAD_HISTOGRAM(
157 "PageLoad.Clients.Protocol.QUIC.DocumentTiming." 177 "PageLoad.Clients.Protocol.QUIC.DocumentTiming."
158 "NavigationToDOMContentLoadedEventFired", 178 "NavigationToDOMContentLoadedEventFired",
159 timing.dom_content_loaded_event_start.value()); 179 timing.dom_content_loaded_event_start.value());
160 break; 180 break;
161 } 181 }
162 } 182 }
163 183
164 void ProtocolPageLoadMetricsObserver::OnLoadEventStart( 184 void ProtocolPageLoadMetricsObserver::OnLoadEventStart(
165 const page_load_metrics::PageLoadTiming& timing, 185 const page_load_metrics::PageLoadTiming& timing,
(...skipping 13 matching lines...) Expand all
179 "PageLoad.Clients.Protocol.H11.DocumentTiming." 199 "PageLoad.Clients.Protocol.H11.DocumentTiming."
180 "NavigationToLoadEventFired", 200 "NavigationToLoadEventFired",
181 timing.load_event_start.value()); 201 timing.load_event_start.value());
182 break; 202 break;
183 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: 203 case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
184 PAGE_LOAD_HISTOGRAM( 204 PAGE_LOAD_HISTOGRAM(
185 "PageLoad.Clients.Protocol.H2.DocumentTiming." 205 "PageLoad.Clients.Protocol.H2.DocumentTiming."
186 "NavigationToLoadEventFired", 206 "NavigationToLoadEventFired",
187 timing.load_event_start.value()); 207 timing.load_event_start.value());
188 break; 208 break;
189 case net::HttpResponseInfo::CONNECTION_INFO_QUIC: 209 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
210 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
211 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_33:
212 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_34:
213 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_35:
214 case net::HttpResponseInfo::CONNECTION_INFO_QUIC_36:
190 PAGE_LOAD_HISTOGRAM( 215 PAGE_LOAD_HISTOGRAM(
191 "PageLoad.Clients.Protocol.QUIC.DocumentTiming." 216 "PageLoad.Clients.Protocol.QUIC.DocumentTiming."
192 "NavigationToLoadEventFired", 217 "NavigationToLoadEventFired",
193 timing.load_event_start.value()); 218 timing.load_event_start.value());
194 break; 219 break;
195 } 220 }
196 } 221 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698