Issue 246163006: Move history serialization from contet/public/renderer/ to content/renderer/

Issue 246163006: Move history serialization from contet/public/renderer/ to content/renderer/ (Closed)

Created:
6 years, 8 months ago by Nate Chapin

Modified:
6 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move history serialization from contet/public/renderer/ to content/renderer/ The only reason it is in content/public/ is so that content/shell can dump history state for testing. Move back/forward list dumping to content/test/. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266158

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix braces #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -313 lines)			Patch
M	content/content_renderer.gypi	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/public/renderer/history_item_serialization.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
D	content/public/renderer/history_item_serialization.cc	View		1 chunk	+0 lines, -192 lines	0 comments	Download
M	content/public/test/layouttest_support.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	content/public/test/render_view_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/context_menu_params_builder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/renderer/history_serialization.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/renderer/history_serialization.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/WebTestDelegate.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebTestProxy.cpp	View		1 chunk	+2 lines, -63 lines	0 comments	Download
M	content/shell/renderer/webkit_test_runner.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	content/shell/renderer/webkit_test_runner.cc	View		3 chunks	+4 lines, -14 lines	0 comments	Download
M	content/test/layouttest_support.cc	View	1 2	2 chunks	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/246163006/diff/20001/content/test/layouttest_support.cc File content/test/layouttest_support.cc (right): https://codereview.chromium.org/246163006/diff/20001/content/test/layouttest_support.cc#newcode175 content/test/layouttest_support.cc:175: { nit: brace bracket on previous line. also ...

6 years, 8 months ago (2014-04-24 16:23:26 UTC) #2

Nate Chapin

https://codereview.chromium.org/246163006/diff/20001/content/test/layouttest_support.cc File content/test/layouttest_support.cc (right): https://codereview.chromium.org/246163006/diff/20001/content/test/layouttest_support.cc#newcode175 content/test/layouttest_support.cc:175: { On 2014/04/24 16:23:26, jam wrote: > nit: brace ...

6 years, 8 months ago (2014-04-24 18:56:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/246163006/40001

6 years, 8 months ago (2014-04-24 21:47:06 UTC) #9

Message was sent while issue was closed.

Change committed as 266158

Expand Messages | Collapse Messages