Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3569)

Unified Diff: content/shell/renderer/webkit_test_runner.cc

Issue 246163006: Move history serialization from contet/public/renderer/ to content/renderer/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix braces Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/webkit_test_runner.h ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/webkit_test_runner.cc
diff --git a/content/shell/renderer/webkit_test_runner.cc b/content/shell/renderer/webkit_test_runner.cc
index 5e96587bba095ce46d7848724f8979ae2eb5e6fb..f0454e120f67f5daa9b305dbf985642f69db8c17 100644
--- a/content/shell/renderer/webkit_test_runner.cc
+++ b/content/shell/renderer/webkit_test_runner.cc
@@ -22,7 +22,6 @@
#include "base/time/time.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/url_constants.h"
-#include "content/public/renderer/history_item_serialization.h"
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/render_view_visitor.h"
#include "content/public/test/layouttest_support.h"
@@ -540,10 +539,7 @@ bool WebKitTestRunner::allowExternalPages() {
return test_config_.allow_external_pages;
}
-void WebKitTestRunner::captureHistoryForWindow(
- WebTestProxyBase* proxy,
- WebVector<blink::WebHistoryItem>* history,
- size_t* currentEntryIndex) {
+std::string WebKitTestRunner::dumpHistoryForWindow(WebTestProxyBase* proxy) {
size_t pos = 0;
std::vector<int>::iterator id;
for (id = routing_ids_.begin(); id != routing_ids_.end(); ++id, ++pos) {
@@ -558,16 +554,10 @@ void WebKitTestRunner::captureHistoryForWindow(
if (id == routing_ids_.end()) {
NOTREACHED();
- return;
- }
- size_t num_entries = session_histories_[pos].size();
- *currentEntryIndex = current_entry_indexes_[pos];
- WebVector<WebHistoryItem> result(num_entries);
- for (size_t entry = 0; entry < num_entries; ++entry) {
- result[entry] =
- PageStateToHistoryItem(session_histories_[pos][entry]);
+ return std::string();
}
- history->swap(result);
+ return DumpBackForwardList(session_histories_[pos],
+ current_entry_indexes_[pos]);
}
// RenderViewObserver --------------------------------------------------------
« no previous file with comments | « content/shell/renderer/webkit_test_runner.h ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698