Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2461463002: [Sync] Replacing NULL with nullptr/null throughout sync code. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Replacing NULL with nullptr/null throughout sync code. BUG=656773 Committed: https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911 Cr-Commit-Position: refs/heads/master@{#428376}

Patch Set 1 #

Patch Set 2 : Reverted PROFILE_nullptr mistake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -399 lines) Patch
M chrome/browser/sync/glue/synced_window_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_factory_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_global_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 12 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_arc_package_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_auth_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_datatype_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 83 chunks +249 lines, -244 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/browser_sync/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/browser_sync/profile_sync_service_bookmark_unittest.cc View 14 chunks +19 lines, -19 lines 0 comments Download
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/test_profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_sessions/favicon_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/session_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M components/sync_sessions/sync_sessions_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/synced_session_tracker.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
skym
PTAL
4 years, 1 month ago (2016-10-27 18:01:38 UTC) #5
maxbogue
lgtm. why're your bots purple? that's weird.
4 years, 1 month ago (2016-10-27 23:02:48 UTC) #9
skym
On 2016/10/27 23:02:48, maxbogue wrote: > lgtm. why're your bots purple? that's weird. I'm not ...
4 years, 1 month ago (2016-10-27 23:05:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461463002/20001
4 years, 1 month ago (2016-10-27 23:06:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/169667)
4 years, 1 month ago (2016-10-28 00:27:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461463002/20001
4 years, 1 month ago (2016-10-28 14:50:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 15:23:21 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 15:49:00 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911
Cr-Commit-Position: refs/heads/master@{#428376}

Powered by Google App Engine
This is Rietveld 408576698